Improve CDROM device validation

truenas · May 13, 2024 · 0c80379 · 0c80379
1 parent c1ef176
commit 0c80379
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/middlewared/middlewared/plugins/vm/devices/cdrom.py b/src/middlewared/middlewared/plugins/vm/devices/cdrom.py
@@ -42,6 +42,10 @@ def _validate(self, device, verrors, old=None, vm_instance=None, update=True):
         path = device['attributes']['path']
         if not os.path.exists(path):
             verrors.add('attributes.path', f'Unable to locate CDROM device at {path!r}')
+        elif not path.startswith('/mnt/'):
+            verrors.add('attributes.path', f'Path {path!r} should be under `/mnt/` dir')
+        elif not os.path.isfile(path):
+            verrors.add('attributes.path', f'Path {path!r} is not a file')
         elif not self.middleware.call_sync('vm.device.disk_uniqueness_integrity_check', device, vm_instance):
             verrors.add(
                 'attributes.path',