Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ga4 #177

Merged
merged 4 commits into from
May 19, 2024
Merged

Update ga4 #177

merged 4 commits into from
May 19, 2024

Conversation

mitsut
Copy link
Member

@mitsut mitsut commented May 19, 2024

#176 でGA4対応できていたと思っていたのですが、hugoのアップデートも関連して対応ができていなかったので、
もう一度合わせて送ります。
さらに
webブランチへのpush時にbuildステップを動かしていたのですが、他のブランチでもbuildステップを動かすようにbuildとdeployのステップを分離しました。
これで、他のブランチにpushした時はbuildステップが走り、webブランチにpush(つまりマージ)した時に、deployステップを実行するようにしました。

@mitsut mitsut requested review from tmori and takasehideki May 19, 2024 05:07
Copy link
Member

@takasehideki takasehideki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!!

@mitsut mitsut merged commit 6ed3567 into web May 19, 2024
2 checks passed
@mitsut mitsut deleted the update-GA4 branch May 19, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants