-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(extrinsic_reflector_based_calibrator): add metric plotter for cross validation and add deletion button #145
feat(extrinsic_reflector_based_calibrator): add metric plotter for cross validation and add deletion button #145
Conversation
Thanks for the PR 🎉 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## tier4/universe #145 +/- ##
=================================================
- Coverage 0.95% 0.00% -0.96%
=================================================
Files 269 6 -263
Lines 20905 952 -19953
Branches 383 0 -383
=================================================
- Hits 200 0 -200
+ Misses 20548 952 -19596
+ Partials 157 0 -157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just in case no one told you before. The spellchecker currently fails in the following words:
Putting aside the one that are misspells, abbreviations are marked as unknown by our current dictionary. |
The CalibrationTools s full of misspells, which are going to be fixed in our big next task. They were not caught at the proper time since the dictionary was added after the code was written |
@vividf
|
sensor/extrinsic_reflector_based_calibrator/scripts/metrics_plotter_node.py
Outdated
Show resolved
Hide resolved
...brator/include/extrinsic_reflector_based_calibrator/extrinsic_reflector_based_calibrator.hpp
Outdated
Show resolved
Hide resolved
About the lifetime of markers. |
sensor/extrinsic_reflector_based_calibrator/src/extrinsic_reflector_based_calibrator.cpp
Outdated
Show resolved
Hide resolved
sensor/extrinsic_reflector_based_calibrator/src/extrinsic_reflector_based_calibrator.cpp
Outdated
Show resolved
Hide resolved
@vividf |
Yes, I run it. But seems that I forget to commit it 😅 |
@vividf |
I commit my code but didn't push. And I remember to run precommit. So I run the precommit run -a. There are some error in other code but not mine and it autofix my code (just like what GitHub does) but after that I forget to commit the changes and I push.😅 |
@vividf |
I see. I was taught by another way. Thank you! I will run the -s in the future. |
@vividf |
(signing the commits is an absoluute rule in other Tier IV repositories) |
Understand! I am sorry😓 and thanks for reminding me again. |
No biggie 👍 |
…algorithm Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
sensor/extrinsic_reflector_based_calibrator/scripts/metrics_plotter_node.py
Outdated
Show resolved
Hide resolved
sensor/extrinsic_reflector_based_calibrator/scripts/metrics_plotter_node.py
Outdated
Show resolved
Hide resolved
sensor/extrinsic_reflector_based_calibrator/src/extrinsic_reflector_based_calibrator.cpp
Outdated
Show resolved
Hide resolved
sensor/extrinsic_reflector_based_calibrator/src/extrinsic_reflector_based_calibrator.cpp
Show resolved
Hide resolved
sensor/extrinsic_reflector_based_calibrator/src/extrinsic_reflector_based_calibrator.cpp
Outdated
Show resolved
Hide resolved
sensor/extrinsic_reflector_based_calibrator/src/extrinsic_reflector_based_calibrator.cpp
Outdated
Show resolved
Hide resolved
sensor/extrinsic_reflector_based_calibrator/src/extrinsic_reflector_based_calibrator.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. Only minor details for this round 💪
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
@vividf
When you merge, make sure you use SQUASH AND MERGE.
Otherwise someone will come and complain :)
Description
This PR adds three new features to the radar-lidar calibrator.
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.