feat(ceres_intrinsic_camera_calibrator): ceres-based intrinsic calibrator #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numerical results seem to be the same as opencv but it is way faster when using a large number of calibration images Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
knzo25
changed the title
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## tier4/universe #141 +/- ##
=================================================
- Coverage 0.95% 0.00% -0.96%
=================================================
Files 269 4 -265
Lines 20908 338 -20570
Branches 387 0 -387
=================================================
- Hits 200 0 -200
+ Misses 20551 338 -20213
+ Partials 157 0 -157
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: amadeuszsz <[email protected]>
Signed-off-by: amadeuszsz <[email protected]>
Signed-off-by: amadeuszsz <[email protected]>
… data conditions Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…(was lost in an experimental branch) Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: amadeuszsz <[email protected]>
Signed-off-by: amadeuszsz <[email protected]>
Signed-off-by: amadeuszsz <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
amadeuszsz
requested changes
Oct 23, 2024
| @@ -47,11 +47,13 @@ calibrate( | |||
| const Eigen::MatrixXd & initial_dist_coeffs_eigen, int num_radial_coeffs, int num_rational_coeffs, | |||
| bool use_tangential_distortion, bool verbose) | |||
| { | |||
| int num_dist_coeffs = initial_dist_coeffs_eigen.rows() * initial_dist_coeffs_eigen.cols(); | |||
There was a problem hiding this comment.
nit: narrowing conversion, std::size_t might be applied in both lines
amadeuszsz
approved these changes
Oct 23, 2024
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a ceres-based camera intrinsics calibrator.
Numerical results seem to be the same as opencv but it is way faster when using a large number of calibration images
Description
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.