Ledger Live fix connection errors #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To improve readability.
Disconnect connector on close modal button when the message is not signed. The user can connect sucessfuly with wallet but also can reject the sign message step. If the user rejects the login message signing and closes the modal, they should get back to the initial state of the not connected account.
The wagmi returns the connector object even if we call `disconnect` function. In that case the connector has basic information like: id, name, type and uuid and the status is set to `connected`. So here we need to make sure the `getAccounts` and `getBitcoinAddress` functions exist in the connector object.
Base automatically changed from
ledger-live-new-api-updates
to
ledger-live-updates
October 31, 2024 16:31
nkuba
approved these changes
Oct 31, 2024
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
nkuba
added a commit
that referenced
this pull request
Nov 6, 2024
This is an integration PR that adds the necessary changes for the dapp to run on Ledger Live. Refs: #730 #742 #763 #759, #760, #797, #780, thesis/orangekit#143, thesis/orangekit#144 ### Important note Changes can only be tested in a Ledger Live app built from source. See the [Ledger Live repo](https://github.com/LedgerHQ/ledger-live), how to build from source.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #780
This PR fixes Ledger Live wallet connection bug. If the user rejects the login message signing and closes the modal, they should get back to the initial state of the not-connected account.
Steps to recreate the bug: