Update the dApp to work in Ledger Live #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on the template we want to build the ledger live manifest based on the `mainnet`, `testnet` and `development`config. In config we set the correct id, name and url.
✅ Deploy Preview for acre-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for acre-dapp-testnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This PR adds the Ledger Live connector from the orangekit lib.
This PR integrates the app with OrnageKit which delivers the provider for the Ledger Live App. The implementation of Ledger Live App support should not cause regression for previous solutions. The app should catch via the `embed` parameter in the URL if it works under the Ledger Live App. If such a parameter is found, in the wgami configuration we should specify only one right connector. ### Testing - [ ] Do the account connection (connection + signing the message) - [ ] Do the deposit flow. - [ ] Do the withdraw flow.
nkuba
reviewed
Sep 25, 2024
We configured netlify branch deployments for this feature branch, so we can use `https://ledger-live-updates--acre-dapp-testnet.netlify.app/?embed=ledger-live` here.
nkuba
reviewed
Sep 25, 2024
r-czajkowski
force-pushed
the
ledger-live-updates
branch
from
0c5345b
to
e32336e
Compare
The connection request should run right away when the user opens the modal window.
nkuba
reviewed
Nov 5, 2024
Comment on lines
57
to
58
| eip1193.didUserRejectRequest(error) || | ||
| ledgerLive.didUserRejectRequest(error) |
There was a problem hiding this comment.
Can we combine these two with one common utils function?
Comment on lines
115
to
116
| eip1193.didUserRejectRequest(error) || | ||
| ledgerLive.didUserRejectRequest(error) |
There was a problem hiding this comment.
Can we combine these two with one common utils function?
nkuba
reviewed
Nov 5, 2024
When the modal is open the buttons on the sidebar don't work. This commit fixes it.
The Ledger throws an error with `Signature interrupted by user` message when a user closes the transaction/sign message native window. We check if the error thrown by Ledger has this message and throw `UserRejectedRequestError` from `viem` to be consistent with orangekit package.
`LEDGER` -> `LEDGER_LIVE`.
Update the url to `bitcoin.acre.fi` and `bitcoin.test.acre.fi`.
nkuba
reviewed
Nov 6, 2024
This reverts commit 3ce27f4.
We need a single source of true for a connected Bitcoin address, so we store it in the redux store. Otherwise, the `useEffect` hook that fetches the Bitcoin address causes unnecessary updates of other hooks.
Set the full id in config instead of `acre-<id>` template. The `id` for the mainnet must be just `acre`.
Closes: #795 Closes: #799 Closes: #806 ### Changes <details> <summary>Added `AcrePointsCard` component's conditional tooltip (depends if wallet is connected) </summary> <img width="545" alt="image" src="https://github.com/user-attachments/assets/d85ce22d-5f15-40cd-96d1-4848e0bc73fe"> <img width="545" alt="image" src="https://github.com/user-attachments/assets/7d5b4d5f-a215-4e09-b6f1-ed42573bff0c"> </details> <details> <summary>Added `BeehiveCard` component's tooltip</summary> <img width="545" alt="image" src="https://github.com/user-attachments/assets/7097c3f9-9cc2-47c5-bd50-5d4d77a9df34"> </details> <details> <summary>Added `withToolip` prop to `CurrencyBalance` component which renders full (not truncated) amount of the activity</summary> <img width="651" alt="image" src="https://github.com/user-attachments/assets/493f7d1e-f1a7-41e9-b4d6-b32375833795"> </details> ### Note UI changes (colors, sizes) are not included. This PR includes content/functionality changes only.
kkosiorowska
commented
Nov 6, 2024
| @@ -101,7 +103,7 @@ export const walletSlice = createSlice({ | |||
| const activityId = action.payload | |||
| delete state.latestActivities[activityId] | |||
| }, | |||
| resetState: () => initialState, | |||
| resetState: (state) => ({ ...initialState, address: state.address }), | |||
There was a problem hiding this comment.
Why don't we also reset the address state?
nkuba
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
It seems that there are no more blocking comments. This PR introduces many improvements to both Standalone and Ledger Live dApp and blocks other PRs.
I'll merge this PR, but @r-czajkowski please address all the unresolved comments in a follow-up PR and @kkosiorowska feel free to propose the improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an integration PR that adds the necessary changes for the dapp to run on Ledger Live.
Refs: #730 #742 #763 #759, #760, #797, #780, https://github.com/thesis/orangekit/pull/143, https://github.com/thesis/orangekit/pull/144
Important note
Changes can only be tested in a Ledger Live app built from source. See the Ledger Live repo, how to build from source.