Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract the installer help and params to separate files #2194

Merged

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Nov 5, 2024

By extracting the generated content to separate files and including them the get-params script can automatically overwrite it with the correct content.

By extracting the generated content to separate files and including them
the get-params script can automatically overwrite it with the correct
content.
Copy link
Contributor

@ColeHiggins2 ColeHiggins2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. I can rebase on top of this

@ekohl ekohl merged commit 53d2d84 into theforeman:gh-pages Nov 5, 2024
2 checks passed
@ekohl ekohl deleted the extract-installer-options-and-include-them branch November 5, 2024 18:06
@ekohl
Copy link
Member Author

ekohl commented Nov 5, 2024

Note I didn't update the files, just refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants