Add 3.13 folder and update nightly #2192
Merged
+10,581
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ColeHiggins2
commented
Nov 5, 2024
| </tbody> | ||
| </table> | ||
| </div> | ||
| <td style='white-space:nowrap'>--puppet-dir-group</td> |
There was a problem hiding this comment.
@ekohl Is this supposed to be separated from the table?
ekohl
changed the title
ekohl
reviewed
Nov 5, 2024
| <td style='white-space:nowrap'>--puppet-dir-group</td> | ||
| <td>Group of the base puppet directory, used when puppet::server is false.</td> | ||
| <div id="all-installer-options"> | ||
| <table class="table table-bordered table-condensed"> |
There was a problem hiding this comment.
This looks odd here. Was the text inserted twice?
There was a problem hiding this comment.
I just copied the output and replaced what was there... So what we see is what was generated
|
#2194 was merged, so there's now a merge conflict. |
ColeHiggins2
force-pushed
the
3.13-branch
branch
from
1bb6f4d to
fcd956b
Compare
ekohl
reviewed
Nov 5, 2024
There was a problem hiding this comment.
@evgeni this is quoting a lot more than I expected. It's not wrong, but really shows there were many (potential) issues before.
ekohl
requested changes
Nov 5, 2024
| More information about compute resources can be found in the [Compute Resources section](/manuals/{{page.version}}/index.html#5.2ComputeResources) and plugins in the [Plugins section](/manuals/{{page.version}}/index.html#6.Plugins). | ||
|
|
||
| <!-- Generated based on `foreman-installer -h | grep enable-` --> | ||
| <div> |
There was a problem hiding this comment.
Please make sure this is equal to nightly
There was a problem hiding this comment.
The script didn't do this... I had to manually create these files to match nightly
ekohl
approved these changes
Nov 5, 2024
ekohl
added a commit
to ekohl/theforeman.org
that referenced
this pull request
Dec 6, 2024
Fixes: bde7e8b ("Add 3.13 folder and update nightly (theforeman#2192)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.