Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execution: initialize next in aggregation even if we aggregate the labels away #504

Merged
merged 2 commits into from
Jan 3, 2025
Merged

execution: initialize next in aggregation even if we aggregate the labels away #504

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ac60cf
execution: initialize next in aggregation even if we aggregate the la…
Jan 3, 2025
00e6757
execute: review on execution/aggregate/hashaggregate.go
MichaHoffmann Jan 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions execution/aggregate/hashaggregate.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,10 @@ func (a *aggregate) initializeTables(ctx context.Context) error {
}

func (a *aggregate) initializeVectorizedTables(ctx context.Context) ([]aggregateTable, []labels.Labels, error) {
// perform initialization of the underlying operator even if we are aggregating the labels away
if _, err := a.next.Series(ctx); err != nil {
return nil, nil, err
}
tables, err := newVectorizedTables(a.stepsBatch, a.aggregation)
if errors.Is(err, parse.ErrNotSupportedExpr) {
return a.initializeScalarTables(ctx)
Expand Down
Loading