execution: initialize next in aggregation even if we aggregate the labels away #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bels away Signed-off-by: Michael Hoffmann <[email protected]>
MichaHoffmann
force-pushed
the
mhoffmann/initialize-next-even-if-we-aggregate-its-labels-away
branch
from
d0576aa to
2ac60cf
Compare
|
Traces show that some binary expressions execute each of their arms sequentially instead of parallel, traced it to this missing initialization: |
fpetkovski
approved these changes
Jan 3, 2025
yeya24
approved these changes
Jan 3, 2025
Co-authored-by: Filip Petkovski <[email protected]> Signed-off-by: Michael Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In aggregations where we aggregate all labels away ( like sum(X) ) we are lazily initializing the "next" vector operator. This leads to us not parallelizing initialization if we are executing queries like
sum by (foo) (X) / on () group_left () sum(X). If initialization is expensive, for example in distributed engine; this double query latency.