Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail if core=tarantool default server failed #441

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fail if core=tarantool default server failed #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ def run(self, server):
sys.stdout.flush()

is_tap = False
is_crashed = False
if not self.skip:
if not os.path.exists(self.tmp_result):
self.is_executed_ok = False
Expand All @@ -233,6 +234,9 @@ def run(self, server):
is_tap, is_ok, is_skip = self.check_tap_output()
self.is_equal_result = is_ok
self.skip = is_skip

server.stop(silent=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems, this patch is not enough to fail on the scenario from #416, because SIGABRT is considered as OK (it was added as part of the #398 fix).

is_crashed = server.current_test.is_crash_reported
else:
self.is_equal_result = 1

Expand All @@ -250,7 +254,8 @@ def run(self, server):
os.remove(self.tmp_result)
elif (self.is_executed_ok and
self.is_equal_result and
self.is_valgrind_clean):
self.is_valgrind_clean and
not is_crashed):
short_status = 'pass'
color_stdout("[ pass ]\n", schema='test_pass')
if os.path.exists(self.tmp_result):
Expand Down
Loading