Fail if core=tarantool default server failed #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we stop default server in worker run loop only before the next test start. So the previous test does not account whether the Tarantool executing the test exits successfully or not. Thus we do not fail on memory leaks for example. Let's stop the server and account its exit status in test. Closes tarantool#416
ylobankov
approved these changes
Aug 1, 2024
Totktonada
reviewed
Aug 2, 2024
| @@ -233,6 +234,9 @@ def run(self, server): | |||
| is_tap, is_ok, is_skip = self.check_tap_output() | |||
| self.is_equal_result = is_ok | |||
| self.skip = is_skip | |||
|
|
|||
| server.stop(silent=True) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we stop default server in worker run loop only before the next test start. So the previous test does not account whether the Tarantool executing the test exits successfully or not. Thus we do not fail on memory leaks for example.
Let's stop the server and account its exit status in test.
Closes #416