Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.12.1 #325

Merged
merged 6 commits into from
Aug 7, 2023
Merged

Release 1.12.1 #325

merged 6 commits into from
Aug 7, 2023

Commits on Aug 3, 2023

  1. test: fix flaky decimal.TestSelect 

    We forgot to increase the timeout [1] when we fixed tests for macos.

1. 521c0c3

(cherry picked from 6cddcd7)
    @oleg-jukovec
    oleg-jukovec committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d2b2b0a View commit details
    Browse the repository at this point in the history

  2. queue: encode UUID argument of identify() as string instead of binary 

    The identify() function expects the UUID argument to be a plain string
while the go connector encodes it in MsgPack as a binary blob (MP_BIN).
This works fine for now because Tarantool stores MP_BIN data in a string
when decoded to Lua but this behavior is going to change soon: we're
planning to introduce the new Lua type for binary data and update the
MsgPack decoder to store MP_BIN data in a varbianry object instead of
a plain string.

Let's prepare for that by converting the UUID data to a string before
encoding.

Needed for tarantool/tarantool#1629

(cherry picked from c2498be)
    @locker @oleg-jukovec
    locker authored and oleg-jukovec committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    d37e9b5 View commit details
    Browse the repository at this point in the history

  3. pool: fix race condition at GetNextConnection() 

    The `r.current` value can be changed by concurrent threads because
the change happens under read-lock. We could use the atomic counter
for a current connection number to avoid the race condition.

Closes #309

(cherry picked from dbfaab5)
    @oleg-jukovec
    oleg-jukovec committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    bf27cc9 View commit details
    Browse the repository at this point in the history

  4. decimal: incorrect MP_DECIMAL decoding with scale < 0 

    The `scale` value in `MP_DECIMAL` may be negative [1]. We need
to handle the case.

1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/msgpack_extensions/#the-decimal-type

(cherry picked from 3aeb8c2)
    @oleg-jukovec
    oleg-jukovec committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    317d100 View commit details
    Browse the repository at this point in the history

  5. crud: fix options for SelectRequest 

    The patch fixes a typo that made it impossible to setup
SelectOpts.After, SelectOpts.BatchSize and SelectOpts.ForceMapCall.

Part of #320

(cherry picked from f56fb90)
    @oleg-jukovec
    oleg-jukovec committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    bd36edb View commit details
    Browse the repository at this point in the history

  6. Release 1.12.1 

    Overview

    The patch release imports fixes from the master branch.

Breaking changes

    There are no breaking changes in the release.

Bugfixes

    Flaky decimal/TestSelect (#300).

    Race condition at roundRobinStrategy.GetNextConnection() (#309).

    Incorrect decoding of an MP_DECIMAL when the `scale` value is
    negative (#314).

    Incorrect options (`after`, `batch_size` and `force_map_call`)
    setup for crud.SelectRequest (#320).

Other

    Change encoding of the queue.Identify() UUID argument from binary
    blob to plain string. Needed for upgrade to Tarantool 3.0, where a
    binary blob is decoded to a varbinary object (#313).
    @oleg-jukovec
    oleg-jukovec committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    0402552 View commit details
    Browse the repository at this point in the history