forked from fl00r/go-tarantool-1.6
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.12.1 #325
Merged
Merged
Release 1.12.1 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleg-jukovec
force-pushed
the
release/1.12
branch
from
August 3, 2023 10:44
8f9b5ea
to
403f2c3
Compare
oleg-jukovec
force-pushed
the
oleg-jukovec/release-1.12.1
branch
from
August 3, 2023 10:47
723c344
to
7440c89
Compare
2 tasks
The identify() function expects the UUID argument to be a plain string while the go connector encodes it in MsgPack as a binary blob (MP_BIN). This works fine for now because Tarantool stores MP_BIN data in a string when decoded to Lua but this behavior is going to change soon: we're planning to introduce the new Lua type for binary data and update the MsgPack decoder to store MP_BIN data in a varbianry object instead of a plain string. Let's prepare for that by converting the UUID data to a string before encoding. Needed for tarantool/tarantool#1629 (cherry picked from c2498be)
The `scale` value in `MP_DECIMAL` may be negative [1]. We need to handle the case. 1. https://www.tarantool.io/en/doc/latest/dev_guide/internals/msgpack_extensions/#the-decimal-type (cherry picked from 3aeb8c2)
Overview The patch release imports fixes from the master branch. Breaking changes There are no breaking changes in the release. Bugfixes Flaky decimal/TestSelect (#300). Race condition at roundRobinStrategy.GetNextConnection() (#309). Incorrect decoding of an MP_DECIMAL when the `scale` value is negative (#314). Incorrect options (`after`, `batch_size` and `force_map_call`) setup for crud.SelectRequest (#320). Other Change encoding of the queue.Identify() UUID argument from binary blob to plain string. Needed for upgrade to Tarantool 3.0, where a binary blob is decoded to a varbinary object (#313).
oleg-jukovec
force-pushed
the
oleg-jukovec/release-1.12.1
branch
from
August 3, 2023 11:23
7440c89
to
0402552
Compare
thank you |
DifferentialOrange
approved these changes
Aug 3, 2023
DerekBum
approved these changes
Aug 7, 2023
Thank you for the issue, released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The patch release imports fixes from the master branch.
Breaking changes
There are no breaking changes in the release.
Bugfixes
scale
value is negative (decimal: incorrect MP_DECIMAL decoding with scale < 0 #314).after
,batch_size
andforce_map_call
) setup for crud.SelectRequest (How implement struct for use in crud insert request? #320).Other
identify()
as string instead of binary #313).