Merge branch 'develop-rc' into develop-mvlookup #32
Clippy (1.56.1)
20 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 20 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.63.0 (4b91a6ea7 2022-08-08)
- cargo 1.63.0 (fd9c4297c 2022-07-01)
- clippy 0.1.63 (4b91a6e 2022-08-08)
Annotations
Check failure on line 193 in halo2_proofs/src/arithmetic.rs
github-actions / Clippy (1.56.1)
unused unary operation that must be used
error: unused unary operation that must be used
--> halo2_proofs/src/arithmetic.rs:188:9
|
188 | / *FFT_COUNTER
189 | | .lock()
190 | | .unwrap()
191 | | .entry(a.len())
192 | | .and_modify(|cnt| *cnt += 1)
193 | | .or_insert(1);
| |_________________________^ the unary operation produces a value
|
help: use `let _ = ...` to ignore the resulting value
|
188 | let _ = *FFT_COUNTER
| +++++++
Check failure on line 143 in halo2_proofs/src/arithmetic.rs
github-actions / Clippy (1.56.1)
unused unary operation that must be used
error: unused unary operation that must be used
--> halo2_proofs/src/arithmetic.rs:138:9
|
138 | / *MSM_COUNTER
139 | | .lock()
140 | | .unwrap()
141 | | .entry(coeffs.len())
142 | | .and_modify(|cnt| *cnt += 1)
143 | | .or_insert(1);
| |_________________________^ the unary operation produces a value
|
= note: `-D unused-must-use` implied by `-D warnings`
help: use `let _ = ...` to ignore the resulting value
|
138 | let _ = *MSM_COUNTER
| +++++++
Check failure on line 1645 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (1.56.1)
the loop variable `i` is only used to index `args`
error: the loop variable `i` is only used to index `args`
--> halo2_proofs/src/plonk/circuit.rs:1645:26
|
1645 | for i in 0..args.len() {
| ^^^^^^^^^^^^^
|
= note: `-D clippy::needless-range-loop` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
1645 | for <item> in &mut args {
| ~~~~~~ ~~~~~~~~~
Check failure on line 1582 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (1.56.1)
avoid using `collect()` when not needed
error: avoid using `collect()` when not needed
--> halo2_proofs/src/plonk/circuit.rs:1582:14
|
1582 | .collect();
| ^^^^^^^
...
1585 | table_map.into_iter().unzip();
| --------------------- the iterator could be used here instead
|
= note: `-D clippy::needless-collect` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
help: use the original Iterator instead of collecting it and then producing a new one
|
1571 ~
1572 |
1573 | let (input_expressions, table_expressions): (Vec<_>, Vec<_>) =
1574 ~ table_map(&mut cells)
1575 + .into_iter()
1576 + .map(|(input, table)| {
1577 + if input.contains_simple_selector() {
1578 + panic!("expression containing simple selector supplied to lookup argument");
1579 + }
1580 +
1581 + let table = cells.query_fixed(table.inner(), Rotation::cur());
1582 +
1583 + (input, table)
1584 ~ }).unzip();
|
Check failure on line 193 in halo2_proofs/src/arithmetic.rs
github-actions / Clippy (1.56.1)
unused unary operation that must be used
error: unused unary operation that must be used
--> halo2_proofs/src/arithmetic.rs:188:9
|
188 | / *FFT_COUNTER
189 | | .lock()
190 | | .unwrap()
191 | | .entry(a.len())
192 | | .and_modify(|cnt| *cnt += 1)
193 | | .or_insert(1);
| |_________________________^ the unary operation produces a value
|
help: use `let _ = ...` to ignore the resulting value
|
188 | let _ = *FFT_COUNTER
| +++++++
Check failure on line 143 in halo2_proofs/src/arithmetic.rs
github-actions / Clippy (1.56.1)
unused unary operation that must be used
error: unused unary operation that must be used
--> halo2_proofs/src/arithmetic.rs:138:9
|
138 | / *MSM_COUNTER
139 | | .lock()
140 | | .unwrap()
141 | | .entry(coeffs.len())
142 | | .and_modify(|cnt| *cnt += 1)
143 | | .or_insert(1);
| |_________________________^ the unary operation produces a value
|
= note: `-D unused-must-use` implied by `-D warnings`
help: use `let _ = ...` to ignore the resulting value
|
138 | let _ = *MSM_COUNTER
| +++++++
Check failure on line 193 in halo2_proofs/src/arithmetic.rs
github-actions / Clippy (1.56.1)
unnecessary operation
error: unnecessary operation
--> halo2_proofs/src/arithmetic.rs:188:9
|
188 | / *FFT_COUNTER
189 | | .lock()
190 | | .unwrap()
191 | | .entry(a.len())
192 | | .and_modify(|cnt| *cnt += 1)
193 | | .or_insert(1);
| |__________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
help: statement can be reduced to
|
188 ~ FFT_COUNTER
189 + .lock()
190 + .unwrap()
191 + .entry(a.len())
192 + .and_modify(|cnt| *cnt += 1)
193 + .or_insert(1);
|
Check failure on line 143 in halo2_proofs/src/arithmetic.rs
github-actions / Clippy (1.56.1)
unnecessary operation
error: unnecessary operation
--> halo2_proofs/src/arithmetic.rs:138:9
|
138 | / *MSM_COUNTER
139 | | .lock()
140 | | .unwrap()
141 | | .entry(coeffs.len())
142 | | .and_modify(|cnt| *cnt += 1)
143 | | .or_insert(1);
| |__________________________^
|
= note: `-D clippy::unnecessary-operation` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
help: statement can be reduced to
|
138 ~ MSM_COUNTER
139 + .lock()
140 + .unwrap()
141 + .entry(coeffs.len())
142 + .and_modify(|cnt| *cnt += 1)
143 + .or_insert(1);
|
Check failure on line 56 in halo2_proofs/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
variant `Gamma` is never constructed
error: variant `Gamma` is never constructed
--> halo2_proofs/src/plonk/evaluation.rs:56:5
|
40 | pub enum ValueSource {
| ----------- variant in this enum
...
56 | Gamma(),
| ^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= note: `ValueSource` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
Check failure on line 1645 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (1.56.1)
the loop variable `i` is only used to index `args`
error: the loop variable `i` is only used to index `args`
--> halo2_proofs/src/plonk/circuit.rs:1645:26
|
1645 | for i in 0..args.len() {
| ^^^^^^^^^^^^^
|
= note: `-D clippy::needless-range-loop` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
|
1645 | for <item> in &mut args {
| ~~~~~~ ~~~~~~~~~
Check failure on line 1582 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (1.56.1)
avoid using `collect()` when not needed
error: avoid using `collect()` when not needed
--> halo2_proofs/src/plonk/circuit.rs:1582:14
|
1582 | .collect();
| ^^^^^^^
...
1585 | table_map.into_iter().unzip();
| --------------------- the iterator could be used here instead
|
= note: `-D clippy::needless-collect` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
help: use the original Iterator instead of collecting it and then producing a new one
|
1571 ~
1572 |
1573 | let (input_expressions, table_expressions): (Vec<_>, Vec<_>) =
1574 ~ table_map(&mut cells)
1575 + .into_iter()
1576 + .map(|(input, table)| {
1577 + if input.contains_simple_selector() {
1578 + panic!("expression containing simple selector supplied to lookup argument");
1579 + }
1580 +
1581 + let table = cells.query_fixed(table.inner(), Rotation::cur());
1582 +
1583 + (input, table)
1584 ~ }).unzip();
|
Check failure on line 193 in halo2_proofs/src/arithmetic.rs
github-actions / Clippy (1.56.1)
unnecessary operation
error: unnecessary operation
--> halo2_proofs/src/arithmetic.rs:188:9
|
188 | / *FFT_COUNTER
189 | | .lock()
190 | | .unwrap()
191 | | .entry(a.len())
192 | | .and_modify(|cnt| *cnt += 1)
193 | | .or_insert(1);
| |__________________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
help: statement can be reduced to
|
188 ~ FFT_COUNTER
189 + .lock()
190 + .unwrap()
191 + .entry(a.len())
192 + .and_modify(|cnt| *cnt += 1)
193 + .or_insert(1);
|
Check failure on line 143 in halo2_proofs/src/arithmetic.rs
github-actions / Clippy (1.56.1)
unnecessary operation
error: unnecessary operation
--> halo2_proofs/src/arithmetic.rs:138:9
|
138 | / *MSM_COUNTER
139 | | .lock()
140 | | .unwrap()
141 | | .entry(coeffs.len())
142 | | .and_modify(|cnt| *cnt += 1)
143 | | .or_insert(1);
| |__________________________^
|
= note: `-D clippy::unnecessary-operation` implied by `-D warnings`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
help: statement can be reduced to
|
138 ~ MSM_COUNTER
139 + .lock()
140 + .unwrap()
141 + .entry(coeffs.len())
142 + .and_modify(|cnt| *cnt += 1)
143 + .or_insert(1);
|
Check failure on line 56 in halo2_proofs/src/plonk/evaluation.rs
github-actions / Clippy (1.56.1)
variant `Gamma` is never constructed
error: variant `Gamma` is never constructed
--> halo2_proofs/src/plonk/evaluation.rs:56:5
|
40 | pub enum ValueSource {
| ----------- variant in this enum
...
56 | Gamma(),
| ^^^^^^^
|
= note: `-D dead-code` implied by `-D warnings`
= note: `ValueSource` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
Check failure on line 448 in halo2_proofs/src/dev/failure.rs
github-actions / Clippy (1.56.1)
unused variable: `name`
error: unused variable: `name`
--> halo2_proofs/src/dev/failure.rs:448:5
|
448 | name: &str,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
Check failure on line 1677 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (1.56.1)
unused variable: `name`
error: unused variable: `name`
--> halo2_proofs/src/plonk/circuit.rs:1677:9
|
1677 | name: &'static str,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
Check failure on line 1567 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (1.56.1)
unused variable: `name`
error: unused variable: `name`
--> halo2_proofs/src/plonk/circuit.rs:1567:9
|
1567 | name: &'static str,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
|
= note: `-D unused-variables` implied by `-D warnings`
Check failure on line 448 in halo2_proofs/src/dev/failure.rs
github-actions / Clippy (1.56.1)
unused variable: `name`
error: unused variable: `name`
--> halo2_proofs/src/dev/failure.rs:448:5
|
448 | name: &str,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
Check failure on line 1677 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (1.56.1)
unused variable: `name`
error: unused variable: `name`
--> halo2_proofs/src/plonk/circuit.rs:1677:9
|
1677 | name: &'static str,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
Check failure on line 1567 in halo2_proofs/src/plonk/circuit.rs
github-actions / Clippy (1.56.1)
unused variable: `name`
error: unused variable: `name`
--> halo2_proofs/src/plonk/circuit.rs:1567:9
|
1567 | name: &'static str,
| ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
|
= note: `-D unused-variables` implied by `-D warnings`