warning: unused variable: `k`
   --> halo2_proofs/benches/lookups.rs:163:15
    |
163 |     fn prover(k: u32, params: &ParamsKZG<Bn256>, pk: &ProvingKey<G1Affine>) -> Vec<u8> {
    |               ^ help: if this is intentional, prefix it with an underscore: `_k`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: consider removing unnecessary double parentheses
   --> halo2_proofs/benches/lookups.rs:144:53
    |
144 | ...                   || Value::known(F::from((offset % 256))),
    |                                               ^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens

warning: consider removing unnecessary double parentheses
   --> halo2_proofs/benches/lookups.rs:135:53
    |
135 | ...                   || Value::known(F::from((offset % 256))),
    |                                               ^^^^^^^^^^^^^^
    |
    = note: `-W clippy::double-parens` implied by `-W clippy::all`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens

warning: unnecessary parentheses around function argument
   --> halo2_proofs/benches/lookups.rs:144:53
    |
144 | ...                   || Value::known(F::from((offset % 256))),
    |                                               ^            ^
    |
help: remove these parentheses
    |
144 -                             || Value::known(F::from((offset % 256))),
144 +                             || Value::known(F::from(offset % 256)),
    |

warning: unnecessary parentheses around function argument
   --> halo2_proofs/benches/lookups.rs:135:53
    |
135 | ...                   || Value::known(F::from((offset % 256))),
    |                                               ^            ^
    |
    = note: `#[warn(unused_parens)]` on by default
help: remove these parentheses
    |
135 -                             || Value::known(F::from((offset % 256))),
135 +                             || Value::known(F::from(offset % 256)),
    |

warning: unused unary operation that must be used
   --> halo2_proofs/src/arithmetic.rs:188:9
    |
188 | /         *FFT_COUNTER
189 | |             .lock()
190 | |             .unwrap()
191 | |             .entry(a.len())
192 | |             .and_modify(|cnt| *cnt += 1)
193 | |             .or_insert(1);
    | |_________________________^ the unary operation produces a value
    |
help: use `let _ = ...` to ignore the resulting value
    |
188 |         let _ = *FFT_COUNTER
    |         +++++++

warning: unused unary operation that must be used
   --> halo2_proofs/src/arithmetic.rs:138:9
    |
138 | /         *MSM_COUNTER
139 | |             .lock()
140 | |             .unwrap()
141 | |             .entry(coeffs.len())
142 | |             .and_modify(|cnt| *cnt += 1)
143 | |             .or_insert(1);
    | |_________________________^ the unary operation produces a value
    |
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
138 |         let _ = *MSM_COUNTER
    |         +++++++

warning: the loop variable `i` is only used to index `args`
    --> halo2_proofs/src/plonk/circuit.rs:1645:26
     |
1645 |                 for i in 0..args.len() {
     |                          ^^^^^^^^^^^^^
     |
     = note: `-W clippy::needless-range-loop` implied by `-W clippy::all`
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
     |
1645 |                 for <item> in &mut args {
     |                     ~~~~~~    ~~~~~~~~~

warning: unused import: `ff::PrimeField`
 --> halo2_proofs/tests/plonk_api.rs:5:5
  |
5 | use ff::PrimeField;
  |     ^^^^^^^^^^^^^^

warning: unused import: `assert_matches::assert_matches`
 --> halo2_proofs/tests/plonk_api.rs:4:5
  |
4 | use assert_matches::assert_matches;
  |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: `#[warn(unused_imports)]` on by default

warning: avoid using `collect()` when not needed
    --> halo2_proofs/src/plonk/circuit.rs:1582:14
     |
1582 |             .collect();
     |              ^^^^^^^
...
1585 |             table_map.into_iter().unzip();
     |             --------------------- the iterator could be used here instead
     |
     = note: `-W clippy::needless-collect` implied by `-W clippy::all`
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect
help: use the original Iterator instead of collecting it and then producing a new one
     |
1571 ~         
1572 | 
1573 |         let (input_expressions, table_expressions): (Vec<_>, Vec<_>) =
1574 ~             table_map(&mut cells)
1575 +             .into_iter()
1576 +             .map(|(input, table)| {
1577 +                 if input.contains_simple_selector() {
1578 +                     panic!("expression containing simple selector supplied to lookup argument");
1579 +                 }
1580 + 
1581 +                 let table = cells.query_fixed(table.inner(), Rotation::cur());
1582 + 
1583 +                 (input, table)
1584 ~             }).unzip();
     |

warning: unused unary operation that must be used
   --> halo2_proofs/src/arithmetic.rs:188:9
    |
188 | /         *FFT_COUNTER
189 | |             .lock()
190 | |             .unwrap()
191 | |             .entry(a.len())
192 | |             .and_modify(|cnt| *cnt += 1)
193 | |             .or_insert(1);
    | |_________________________^ the unary operation produces a value
    |
help: use `let _ = ...` to ignore the resulting value
    |
188 |         let _ = *FFT_COUNTER
    |         +++++++

warning: unused unary operation that must be used
   --> halo2_proofs/src/arithmetic.rs:138:9
    |
138 | /         *MSM_COUNTER
139 | |             .lock()
140 | |             .unwrap()
141 | |             .entry(coeffs.len())
142 | |             .and_modify(|cnt| *cnt += 1)
143 | |             .or_insert(1);
    | |_________________________^ the unary operation produces a value
    |
    = note: `#[warn(unused_must_use)]` on by default
help: use `let _ = ...` to ignore the resulting value
    |
138 |         let _ = *MSM_COUNTER
    |         +++++++

warning: unnecessary operation
   --> halo2_proofs/src/arithmetic.rs:188:9
    |
188 | /         *FFT_COUNTER
189 | |             .lock()
190 | |             .unwrap()
191 | |             .entry(a.len())
192 | |             .and_modify(|cnt| *cnt += 1)
193 | |             .or_insert(1);
    | |__________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
help: statement can be reduced to
    |
188 ~         FFT_COUNTER
189 +             .lock()
190 +             .unwrap()
191 +             .entry(a.len())
192 +             .and_modify(|cnt| *cnt += 1)
193 +             .or_insert(1);
    |

warning: unnecessary operation
   --> halo2_proofs/src/arithmetic.rs:138:9
    |
138 | /         *MSM_COUNTER
139 | |             .lock()
140 | |             .unwrap()
141 | |             .entry(coeffs.len())
142 | |             .and_modify(|cnt| *cnt += 1)
143 | |             .or_insert(1);
    | |__________________________^
    |
    = note: `-W clippy::unnecessary-operation` implied by `-W clippy::all`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
help: statement can be reduced to
    |
138 ~         MSM_COUNTER
139 +             .lock()
140 +             .unwrap()
141 +             .entry(coeffs.len())
142 +             .and_modify(|cnt| *cnt += 1)
143 +             .or_insert(1);
    |

warning: variant `Gamma` is never constructed
  --> halo2_proofs/src/plonk/evaluation.rs:56:5
   |
40 | pub enum ValueSource {
   |          ----------- variant in this enum
...
56 |     Gamma(),
   |     ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
   = note: `ValueSource` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

warning: the loop variable `i` is only used to index `args`
    --> halo2_proofs/src/plonk/circuit.rs:1645:26
     |
1645 |                 for i in 0..args.len() {
     |                          ^^^^^^^^^^^^^
     |
     = note: `-W clippy::needless-range-loop` implied by `-W clippy::all`
     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator
     |
1645 |                 for <item> in &mut args {
     |                     ~~~~~~    ~~~~~~~~~

warning: unnecessary operation
   --> halo2_proofs/src/arithmetic.rs:188:9
    |
188 | /         *FFT_COUNTER
189 | |             .lock()
190 | |             .unwrap()
191 | |             .entry(a.len())
192 | |             .and_modify(|cnt| *cnt += 1)
193 | |             .or_insert(1);
    | |__________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
help: statement can be reduced to
    |
188 ~         FFT_COUNTER
189 +             .lock()
190 +             .unwrap()
191 +             .entry(a.len())
192 +             .and_modify(|cnt| *cnt += 1)
193 +             .or_insert(1);
    |

warning: unnecessary operation
   --> halo2_proofs/src/arithmetic.rs:138:9
    |
138 | /         *MSM_COUNTER
139 | |             .lock()
140 | |             .unwrap()
141 | |             .entry(coeffs.len())
142 | |             .and_modify(|cnt| *cnt += 1)
143 | |             .or_insert(1);
    | |__________________________^
    |
    = note: `-W clippy::unnecessary-operation` implied by `-W clippy::all`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
help: statement can be reduced to
    |
138 ~         MSM_COUNTER
139 +             .lock()
140 +             .unwrap()
141 +             .entry(coeffs.len())
142 +             .and_modify(|cnt| *cnt += 1)
143 +             .or_insert(1);
    |

warning: variant `Gamma` is never constructed
  --> halo2_proofs/src/plonk/evaluation.rs:56:5
   |
40 | pub enum ValueSource {
   |          ----------- variant in this enum
...
56 |     Gamma(),
   |     ^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default
   = note: `ValueSource` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis

warning: unused variable: `name`
   --> halo2_proofs/src/dev/failure.rs:448:5
    |
448 |     name: &str,
    |     ^^^^ help: if this is intentional, prefix it with an underscore: `_name`

warning: unused variable: `name`
    --> halo2_proofs/src/plonk/circuit.rs:1677:9
     |
1677 |         name: &'static str,
     |         ^^^^ help: if this is intentional, prefix it with an underscore: `_name`

warning: unused variable: `name`
    --> halo2_proofs/src/plonk/circuit.rs:1567:9
     |
1567 |         name: &'static str,
     |         ^^^^ help: if this is intentional, prefix it with an underscore: `_name`
     |
     = note: `#[warn(unused_variables)]` on by default

warning: unused variable: `name`
   --> halo2_proofs/src/dev/failure.rs:448:5
    |
448 |     name: &str,
    |     ^^^^ help: if this is intentional, prefix it with an underscore: `_name`

warning: unused variable: `name`
    --> halo2_proofs/src/plonk/circuit.rs:1677:9
     |
1677 |         name: &'static str,
     |         ^^^^ help: if this is intentional, prefix it with an underscore: `_name`