feat(core): Dialog
move close button inside dialog
#10454
Annotations
8 errors, 10 warnings, and 8 notices
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=s:
projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts#L77
1) [chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=s
Error: Screenshot comparison failed:
247 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/multi-select/multi-select.spec.ts-snapshots/04-dialog-with-text-field-size-s-chromium-linux.png
Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-95876-log-with-tuiTextfieldSize-s-chromium/04-dialog-with-text-field-size-s-actual.png
Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-95876-log-with-tuiTextfieldSize-s-chromium/04-dialog-with-text-field-size-s-diff.png
Call log:
- expect.toHaveScreenshot(04-dialog-with-text-field-size-s.png) with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 247 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 247 pixels (ratio 0.01 of all image pixels) are different.
75 |
76 | await documentationPage.hideContent();
> 77 | await expect(page).toHaveScreenshot(
| ^
78 | `04-dialog-with-text-field-size-${size}.png`,
79 | );
80 | });
at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts:77:40
|
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=s:
projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts#L77
1) [chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=s
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
247 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/multi-select/multi-select.spec.ts-snapshots/04-dialog-with-text-field-size-s-chromium-linux.png
Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-95876-log-with-tuiTextfieldSize-s-chromium-retry1/04-dialog-with-text-field-size-s-actual.png
Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-95876-log-with-tuiTextfieldSize-s-chromium-retry1/04-dialog-with-text-field-size-s-diff.png
Call log:
- expect.toHaveScreenshot(04-dialog-with-text-field-size-s.png) with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 247 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 247 pixels (ratio 0.01 of all image pixels) are different.
75 |
76 | await documentationPage.hideContent();
> 77 | await expect(page).toHaveScreenshot(
| ^
78 | `04-dialog-with-text-field-size-${size}.png`,
79 | );
80 | });
at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts:77:40
|
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=m:
projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts#L77
2) [chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=m
Error: Screenshot comparison failed:
247 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/multi-select/multi-select.spec.ts-snapshots/04-dialog-with-text-field-size-m-chromium-linux.png
Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-c3931-log-with-tuiTextfieldSize-m-chromium/04-dialog-with-text-field-size-m-actual.png
Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-c3931-log-with-tuiTextfieldSize-m-chromium/04-dialog-with-text-field-size-m-diff.png
Call log:
- expect.toHaveScreenshot(04-dialog-with-text-field-size-m.png) with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 247 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 247 pixels (ratio 0.01 of all image pixels) are different.
75 |
76 | await documentationPage.hideContent();
> 77 | await expect(page).toHaveScreenshot(
| ^
78 | `04-dialog-with-text-field-size-${size}.png`,
79 | );
80 | });
at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts:77:40
|
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=m:
projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts#L77
2) [chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=m
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
247 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/multi-select/multi-select.spec.ts-snapshots/04-dialog-with-text-field-size-m-chromium-linux.png
Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-c3931-log-with-tuiTextfieldSize-m-chromium-retry1/04-dialog-with-text-field-size-m-actual.png
Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-c3931-log-with-tuiTextfieldSize-m-chromium-retry1/04-dialog-with-text-field-size-m-diff.png
Call log:
- expect.toHaveScreenshot(04-dialog-with-text-field-size-m.png) with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 247 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 247 pixels (ratio 0.01 of all image pixels) are different.
75 |
76 | await documentationPage.hideContent();
> 77 | await expect(page).toHaveScreenshot(
| ^
78 | `04-dialog-with-text-field-size-${size}.png`,
79 | );
80 | });
at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts:77:40
|
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=l:
projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts#L77
3) [chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=l
Error: Screenshot comparison failed:
247 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/multi-select/multi-select.spec.ts-snapshots/04-dialog-with-text-field-size-l-chromium-linux.png
Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-e3595-log-with-tuiTextfieldSize-l-chromium/04-dialog-with-text-field-size-l-actual.png
Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-e3595-log-with-tuiTextfieldSize-l-chromium/04-dialog-with-text-field-size-l-diff.png
Call log:
- expect.toHaveScreenshot(04-dialog-with-text-field-size-l.png) with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 247 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 247 pixels (ratio 0.01 of all image pixels) are different.
75 |
76 | await documentationPage.hideContent();
> 77 | await expect(page).toHaveScreenshot(
| ^
78 | `04-dialog-with-text-field-size-${size}.png`,
79 | );
80 | });
at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts:77:40
|
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=l:
projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts#L77
3) [chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=l
Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
Error: Screenshot comparison failed:
247 pixels (ratio 0.01 of all image pixels) are different.
Expected: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/snapshots/tests/kit/multi-select/multi-select.spec.ts-snapshots/04-dialog-with-text-field-size-l-chromium-linux.png
Received: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-e3595-log-with-tuiTextfieldSize-l-chromium-retry1/04-dialog-with-text-field-size-l-actual.png
Diff: /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests-results/tests-kit-multi-select-mul-e3595-log-with-tuiTextfieldSize-l-chromium-retry1/04-dialog-with-text-field-size-l-diff.png
Call log:
- expect.toHaveScreenshot(04-dialog-with-text-field-size-l.png) with timeout 5000ms
- verifying given screenshot expectation
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- 247 pixels (ratio 0.01 of all image pixels) are different.
- waiting 100ms before taking screenshot
- taking page screenshot
- disabled all CSS animations
- waiting for fonts to load...
- fonts loaded
- captured a stable screenshot
- 247 pixels (ratio 0.01 of all image pixels) are different.
75 |
76 | await documentationPage.hideContent();
> 77 | await expect(page).toHaveScreenshot(
| ^
78 | `04-dialog-with-text-field-size-${size}.png`,
79 | );
80 | });
at /home/runner/work/taiga-ui/taiga-ui/projects/demo-playwright/tests/kit/multi-select/multi-select.spec.ts:77:40
|
playwright / (4 of 4)
Process completed with exit code 1.
|
E2E result
Process completed with exit code 1.
|
Build demo
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/cache/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
playwright / (1 of 4)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/cache/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
playwright / (3 of 4)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/cache/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
playwright / (4 of 4)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/cache/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
playwright / (2 of 4)
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/cache/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
deep
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/cache/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
core
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/cache/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
kit
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected], actions/cache/[email protected], actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Deprecation notice: v1, v2, and v3 of the artifact actions
The following artifacts were uploaded using a version of actions/upload-artifact that is scheduled for deprecation: "cypress-e2e-artifacts--4cb002cada095c75d99d9be4accfd2474d20b030-11720666177-9712", "playwright-e2e-artifacts--4cb002cada095c75d99d9be4accfd2474d20b030-11720666177-9712".
Please update your workflow to use v4 of the artifact actions.
Learn more: https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
|
E2E result
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
🎭 Playwright Run Summary
94 passed (1.3m)
|
🎭 Playwright Run Summary
94 passed (1.1m)
|
🎭 Playwright Run Summary
93 passed (1.2m)
|
🎭 Playwright Run Summary
93 passed (1.4m)
|
🎭 Playwright Run Summary
3 failed
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=s
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=m
[chromium] › tests/kit/multi-select/multi-select.spec.ts:60:21 › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=l
90 passed (1.4m)
|
🎭 Playwright Run Summary
93 passed (1.4m)
|
🎭 Playwright Run Summary
94 passed (1.6m)
|
🎭 Playwright Run Summary
94 passed (1.3m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
cypress-e2e-artifacts--4cb002cada095c75d99d9be4accfd2474d20b030-11720666177-9712
Expired
|
9.38 MB |
|
playwright-e2e-artifacts--4cb002cada095c75d99d9be4accfd2474d20b030-11720666177-9712
Expired
|
499 KB |
|