Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Dialog move close button inside dialog #9712

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Nov 7, 2024

Fixes #

Copy link

lumberjack-bot bot commented Nov 7, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Visit the preview URL for this PR (updated for commit 4cb002c):

https://taiga-ui--pr9712-mdlufy-dialog-button-4up4h373.web.app

(expires Fri, 08 Nov 2024 10:03:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Nov 7, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
397.78KB (+57B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.53KB +10%
demo/browser/runtime.(hash).js
42.04KB +10%
demo/browser/polyfills.(hash).js
15.2KB +10%
demo/browser/styles.(hash).css
1.39KB +10%

Total files change +57B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.45MB (+521B +0.02%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy marked this pull request as ready for review November 7, 2024 10:36
@mdlufy mdlufy changed the title [WIP] feat(core): Dialog move close button inside dialog feat(core): Dialog move close button inside dialog Nov 7, 2024
@mdlufy mdlufy merged commit 446e2ea into v3.x Nov 7, 2024
33 of 34 checks passed
@mdlufy mdlufy deleted the mdlufy/dialog-button branch November 7, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants