Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kbscan: Switch from GPIO mode to KBS (Normal) mode #362

Merged
merged 2 commits into from
Jul 29, 2023
Merged

kbscan: Switch from GPIO mode to KBS (Normal) mode #362

merged 2 commits into from
Jul 29, 2023

Commits on Jul 25, 2023

  1. kbscan: Switch from GPIO mode to KBS (Normal) mode 

    Use the default mode for reading the keyboard scan matrix when being
used as a keyboard. There should be no perceived change in behavior, but
should make the code easier to understand.

Note: `KSO[17:16]` are configured by `GPCRC` on boards that use them.
They are now set to alternate function to use in KBS mode rather than
GPIO mode, with the pull-up enabled to prevent them from floating when
configured as open-drain.

As part of this change, we now only read the hardware matrix state once
upfront, instead of on every iteration through the loop applying the
logic.

Tested by verifying that typing still works on darp9.

Signed-off-by: Tim Crawford <[email protected]>
    @crawfxrd
    crawfxrd committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    fa9c399 View commit details
    Browse the repository at this point in the history

  2. kbscan: Remove comparing matrix to keymap 

    Remove checking against the real keys declared in the keymap. It appears
to have no effect on behavior.

Signed-off-by: Tim Crawford <[email protected]>
    @crawfxrd
    crawfxrd committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    ea4a015 View commit details
    Browse the repository at this point in the history