kbscan: Switch from GPIO mode to KBS (Normal) mode #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crawfxrd
force-pushed
the
kbs-mode
branch
2 times, most recently
from
ba1aba5
to
48400e0
Compare
crawfxrd
force-pushed
the
kbs-mode
branch
3 times, most recently
from
d691750
to
2709450
Compare
crawfxrd
force-pushed
the
kbs-mode
branch
2 times, most recently
from
c05d9d2
to
dedd488
Compare
crawfxrd
force-pushed
the
kbs-mode
branch
2 times, most recently
from
7d7ffca
to
7847c67
Compare
|
Increases XRAM use by 18 bytes. --- build/system76/oryp8/0/ec.mem 2023-07-17 13:57:23.967001078 -0600
+++ build/system76/oryp8/1/ec.mem 2023-07-17 13:57:34.875145986 -0600
@@ -25,5 +25,5 @@
Name Start End Size Max
---------------- -------- -------- -------- --------
PAGED EXT. RAM 0 256
- EXTERNAL RAM 0x0001 0x051e 1310 2048
- ROM/EPROM/FLASH 0x0000 0x8f8e 36218 65536
+ EXTERNAL RAM 0x0001 0x0530 1328 2048
+ ROM/EPROM/FLASH 0x0000 0x8ed4 36032 65536 |
Closed
Use the default mode for reading the keyboard scan matrix when being used as a keyboard. There should be no perceived change in behavior, but should make the code easier to understand. Note: `KSO[17:16]` are configured by `GPCRC` on boards that use them. They are now set to alternate function to use in KBS mode rather than GPIO mode, with the pull-up enabled to prevent them from floating when configured as open-drain. As part of this change, we now only read the hardware matrix state once upfront, instead of on every iteration through the loop applying the logic. Tested by verifying that typing still works on darp9. Signed-off-by: Tim Crawford <[email protected]>
Remove checking against the real keys declared in the keymap. It appears to have no effect on behavior. Signed-off-by: Tim Crawford <[email protected]>
leviport
approved these changes
Jul 25, 2023
|
May be better to use push-pull (ITE default) rather than open-drain? I can't tell what the ENE chip does. I tried and it was buggy. Open-drain is working so I'll just leave it for now. |
jackpot51
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the default mode for reading the keyboard scan matrix when being used as a keyboard. There should be no perceived change in behavior, but should make the code easier to understand.
Note:
KSO[17:16]are configured byGPRCRCon boards that use them. They are now set to alternate function to use in KBS mode rather than GPIO mode, with the pull-up enabled to prevent them from floating when configured as open-drain.As part of this change, we now only read the hardware matrix state once upfront, instead of on every iteration through the loop applying the logic.
Tested by cherry-picking to darp9 and verifying that typing still worked.
Need to test:
TODO:
kbscan_row_has_ghost())kbscan_get_real_keys()is even needed