Port to python3

[Abhay-dot]

No description provided.

[Abhay-dot]

Ported this repo and tested it, the logs exit with 0 errors [GCI]

[quozl]

One of the print statements has a doubling of parentheses; so I'm not sure if you reviewed each change proposed by 2to3, or if you tested that statement.

[Abhay-dot]

Oops!, thanks for the suggestion, fixed that. I guess I didn’t see that. Thanks, Abhay

…

On Jan 20, 2020, at 05:26, James Cameron ***@***.***> wrote: One of the print statements has a doubling of parentheses; so I'm not sure if you reviewed each change proposed by 2to3, or if you tested that statement.

[quozl]

Tried to test. It doesn't work.

$ sugar-activity3
Traceback (most recent call last):
  File "/usr/bin/sugar-activity3", line 5, in <module>
    activityinstance.main()
  File "/usr/lib/python3.7/dist-packages/sugar3/activity/activityinstance.py", line 179, in main
    module = __import__(module_name)
  File "/usr/share/sugar/activities/Reflect.activity/activity.py", line 45, in <module>
    import telepathy
ModuleNotFoundError: No module named 'telepathy'
$ █

Please see our Python 3 Porting Guide for everything that must be checked.

[Abhay-dot]

Hey, I don't really understand how to do the telepathy porting stuff, is there another more detailed blog or site that tells me what to do? Thanks, Abhay

…

On Jan 20, 2020, at 14:05, James Cameron ***@***.***> wrote: Tried to test. It doesn't work. $ sugar-activity3 Traceback (most recent call last): File "/usr/bin/sugar-activity3", line 5, in <module> activityinstance.main() File "/usr/lib/python3.7/dist-packages/sugar3/activity/activityinstance.py", line 179, in main module = __import__(module_name) File "/usr/share/sugar/activities/Reflect.activity/activity.py", line 45, in <module> import telepathy ModuleNotFoundError: No module named 'telepathy' $ █ Please see our Python 3 Porting Guide <https://github.com/sugarlabs/sugar-docs/blob/master/src/python-porting-guide.md> for everything that must be checked. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13?email_source=notifications&email_token=ANEKZI6VMWETEZ3QSMTSMATQ6U5JVA5CNFSM4KIZL7G2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJLOOQY#issuecomment-576120643>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANEKZI33KUES7XUBFJ5CR4LQ6U5JVANCNFSM4KIZL7GQ>.

[quozl]

Previous work by others, is probably the best. You would look at activities that import TelepathyGLib and evaluate the commits at a diff detail level.

[Abhay-dot]

Hey, I did a few changes using the python porting guide , but there are a few places where this is channel used, i'm not aware of the dbus api. It would be really nice of you if you could review the changes and tell me what else i can do.

[quozl]

Thanks.

You've changed the import in activity.py but the references to telepathy have not changed; so this won't work. It looks like you have not tested collaboration. What testing environment do you have setup for collaboration? You must test what you write.

You changed only CHANNEL, which was an example in the guide to porting. In addition to CHANNEL, every other constant that is imported from the static binding from telepathy import has to change to the corresponding constant from the from gi.repository import TelepathyGLib scope. The constants will be identical in value, but often different in name. (Knowing they will be identical is helpful, because you can run an interactive Python interpreter, import both bindings and experiment with dir().)

However, the source code in the file textchannelwrapper.py is maintained in the CollabWrapper repository, and has already been ported to Python 3 in that repository.

Also, in porting to the latest CollabWrapper, there is no need for any import or use of Telepathy API in the activity.py file.

But the CollabWrapper API may have changed since textchannelwrapper.py was last maintained. Hence collaboration must be tested.

[srevinsaju]

Nice work :) Some minor changes

[quozl]

Thanks. Good progress. I see that the port to TelepathyGLib is not yet complete (static imports of telepathy are present), so I'll wait for that.

[srevinsaju]

Hey, I did a few changes using the python porting guide , but there are a few places where this is channel used, i'm not aware of the dbus api. It would be really nice of you if you could review the changes and tell me what else i can do.

@Abhay-dot I have ported collabwrapper and some telepathy, ported Gconf to Gio.Settings, and some more fixes on Abhay-dot#1. Please review.
I tested the current progress, there are a lot of errors so far within the python3 port alone, but I'm pretty sure we will be able to fix them. You can continue working after merging the PR, so you can checkout the errors and try to fix them,