-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Python3 and Telepathy #15
base: master
Are you sure you want to change the base?
Conversation
get_int for volume instead of get_string removed path because it was used by GConf client
- Change logging.error to logging.debug
Change from file to open
ConfigParser's readfp takes a file opened in text mode as argument. Fixes Error: Traceback (most recent call last): File "/usr/share/sugar/activities/reflect/reflectwindow.py", line 713, in _choose_activity bundle_icons = utils.get_bundle_icons() File "/usr/share/sugar/activities/reflect/utils.py", line 156, in get_bundle_icons _find_bundles() File "/usr/share/sugar/activities/reflect/utils.py", line 141, in _find_bundles cp.readfp(fd) File "/usr/lib/python3.7/configparser.py", line 762, in readfp self.read_file(fp, source=filename) File "/usr/lib/python3.7/configparser.py", line 717, in read_file self._read(f, source) File "/usr/lib/python3.7/configparser.py", line 1030, in _read if line.strip().startswith(prefix): TypeError: startswith first arg must be bytes or a tuple of bytes, not str
Collaboration doesn't work.
I couldn't see what causing the error. Telepathy Port looks correct. @quozl can you review 5c28adb once? |
Which log contains the traceback? Sharer or joiner? Never mind. Comparing
I stopped at that point; there's enough going wrong to make further investigation wasteful and liable to lead you to making point of code changes instead of design changes. The code in porting to CollabWrapper should only use CollabWrapper for collaboration. As it stands at the moment it is a frankenstein mixup. |
5aa05bc
to
187c30b
Compare
Joiner it was.
I have tried to fix port to collabwrapper in 187c30b. It still doesn't work, also no error in logs. |
d63c73a
to
668eade
Compare
You have connected to the activity joined and the CollabWrapper joined signals at the same time, with the same function. You have connected to the activity shared signal, and in response you have posted a message through CollabWrapper, potentially before CollabWrapper has received the shared signal. Please re-read the documentation of the CollabWrapper API. You'll find it at the start of the file, and in the CollabWrapper class. |
f50d77e
to
411c57d
Compare
411c57d
to
4ba35fc
Compare
Collaboration is still broken . |
Following errors have been seen while testing.
In this PR I will try to fix these errors.
I have cherry-picked some of the commits from #13 #14