Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update add_intervals functions with option for days in a year #739

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: update add_intervals functions with option for days in a year #739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions extensions/functions_datetime.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,9 @@ scalar_functions:
value: interval_year
- name: y
value: interval_year
options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would these options also apply to any place an interval was being used?

days_in_year:
values: [ YEAR_366DAYS, YEAR_365DAYS, YEAR_360DAYS ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should hold off on introducing this option without thinking more broadly about this.

Additionally, this concept (days in year) is irrelevant to interval_day and interval_year. Neither of those mix days and years. It is really only relevant when you bring in interval_compound.

return: interval_year
-
name: "subtract"
Expand Down
Loading