feat: update add_intervals functions with option for days in a year #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scgkiran
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
| @@ -374,6 +374,9 @@ scalar_functions: | |||
| value: interval_year | |||
| - name: y | |||
| value: interval_year | |||
| options: | |||
There was a problem hiding this comment.
Would these options also apply to any place an interval was being used?
jacques-n
reviewed
Nov 13, 2024
| @@ -374,6 +374,9 @@ scalar_functions: | |||
| value: interval_year | |||
| - name: y | |||
| value: interval_year | |||
| options: | |||
| days_in_year: | |||
| values: [ YEAR_366DAYS, YEAR_365DAYS, YEAR_360DAYS ] | |||
There was a problem hiding this comment.
I think we should hold off on introducing this option without thinking more broadly about this.
Additionally, this concept (days in year) is irrelevant to interval_day and interval_year. Neither of those mix days and years. It is really only relevant when you bring in interval_compound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.