fix: virtualTable expression should represent a row of expression #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anshuldata
requested review from
jacques-n,
cpcloud,
westonpace,
EpsilonPrime and
vbarua
as code owners
anshuldata
changed the title
anshuldata
changed the title
anshuldata
changed the title
anshuldata
changed the title
|
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
|
@vbarua @EpsilonPrime @westonpace would be good to get your eyes on this so we can fix quickly |
anshuldata
changed the title
westonpace
approved these changes
Oct 29, 2024
|
@anshuldata , this shouldn't have been merged until we had at least 2 SMC approvals since it is a spec change. Please refer to https://substrait.io/governance/#substrait-voting-process in future to make sure we're following process. Thanks! |
got it. I will be careful in future. Thanks for pointing it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: changes the message type for Expressions field in VirtualTable
Fixed issue mentioned in this
I have fixed it by fixing recently introduced field. Though this is a breaking change but since this field is introduced very recently so I assume this won't have many consumers. So, instead of having another field I decided to fix existing field