fix(plan,expr): use Expressions fields in VirtualTable instead of Literal

[anshuldata]

• This change migrates VirtualTable to not use deprecated field and instead use newly introduced field in this PR
• Fix VirtualTable proto to generate Expression Struct instead of Literal Struct
• This PR doesn't have breaking change
• This PR doesn't introduce PublicAPI to use Expression in building VirtualTableRelation. I will introduce it as separate PR

[codecov]

Codecov Report

Attention: Patch coverage is 51.02041% with 24 lines in your changes missing coverage. Please review.

Project coverage is 56.51%. Comparing base (833624e) to head (3be7754).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
plan/internal/helper.go	40.00%	8 Missing and 1 partial ⚠️
expr/expression.go	0.00%	8 Missing ⚠️
plan/plan.go	53.84%	4 Missing and 2 partials ⚠️
plan/relations.go	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   56.56%   56.51%   -0.06%     
==========================================
  Files          38       39       +1     
  Lines        8268     8310      +42     
==========================================
+ Hits         4677     4696      +19     
- Misses       3392     3412      +20     
- Partials      199      202       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[anshuldata]

Converting this PR to draft. I will raise separate PR for proto update. I will rebase and undraft this PR once proto PR is merged

[EpsilonPrime]

This will remove the literal support so consuming older plans won't work but that should be okay given the current usage of this feature.

[anshuldata]

This will remove the literal support so consuming older plans won't work but that should be okay given the current usage of this feature.

@EpsilonPrime this PR does consume older plans. I have added this test case to make sure this. Let me know if I am missing something

[anshuldata]

@zeroshade we need to change github repository setting to not allow merge if change is not approved

We need to add "Branch protection rules" rules as below (Settings --> branches --> Branch protection rules)

[zeroshade]

@anshuldata I don't have the permissions for that.

@jacques-n could you make the suggested change to the branch protection rules?

[jacques-n]

could you make the suggested change to the branch protection rules?

It looks like it is already added. Maybe someone else took the initiative? Or I'm looking in the wrong place...

[EpsilonPrime]

I added them. Looks like we need some added test coverage to merge this PR.

[anshuldata]

Looks like we need some added test coverage to merge this PR.

code coverage doesn't recognize coverage in tests across package. So test in plan_test/plan_builder_test coverage which covers expression.go/helper.go changes is not accounted.
I need to figure out coverage option to detect it