fix_: ensure generated identity-images have a valid clock value #6239
Conversation
seanstrom
force-pushed
the
seanstrom/fix-identity-image-clock
branch
from
b67ad51 to
97b4d83
Compare
Jenkins BuildsClick to see older builds (48)
|
seanstrom
changed the title
|
If I understood correctly and this PR is to fix the issue that images don't re-render properly when they get updated, we also have it. The problem is that we use a local server and the URLs it uses to serve the images only contain a pubkey, which doesn't change when the image being served changes. I fixed that issue for community images here: #6118 I opened a similar issue to do the same thing for profile images here: status-im/status-desktop#16814 So if I'm right with my assessment of the problem you're trying to fix, just applying the same type of fix I did for the community to the profile image should do the trick. Let me know if I misunderstood, if you have questions or if you need help trying to do the same work. @seanstrom |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6239 +/- ##
========================================
Coverage 61.56% 61.56%
========================================
Files 845 845
Lines 110696 110697 +1
========================================
+ Hits 68147 68154 +7
+ Misses 34585 34582 -3
+ Partials 7964 7961 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@jrainville Yup it seems like we're aiming to solve the same problem 🙌 Although I'm a little confused about the difference between I suppose we could create another version map, but maybe we can leverage the |
There was a problem hiding this comment.
Using the clock seems like a simple and effective solution, in a way, it's versioning too. But maybe @jrainville has another idea in mind. Approving in advance anyway.
@seanstrom I'm not sure either. I don't know how the clock works for the images, but I'm also not sure how it would help for the problem we have on Desktop. The clock isn't exposed to the mediaserver as far as I can see, so the URL would still stay the same no, on a Contact for example?
Yeah using the clock in the mediaserver would serve the same purpose as using a local version in the URL. As long as the URL changes from image version to another, it fixes the issue. Either way, as long as the images have a different URL, I'm fine 😄 |
seanstrom
force-pushed
the
seanstrom/fix-identity-image-clock
branch
from
97b4d83 to
f89776c
Compare
|
@jrainville Ahh I see what you mean know about the community images not having a After looking around a little more, I found a utility the function Hopefully this could work for both mobile and desktop 🙏 |
seanstrom
force-pushed
the
seanstrom/fix-identity-image-clock
branch
4 times, most recently
from
2494be9 to
f1ef32f
Compare
|
Just to more ideas on top 😅 We could also use some Any solution will work, and are used in web world. |
seanstrom
force-pushed
the
seanstrom/fix-identity-image-clock
branch
from
f1ef32f to
4239583
Compare
…lock value instead of zero by default
seanstrom
force-pushed
the
seanstrom/fix-identity-image-clock
branch
from
4239583 to
281fb22
Compare
status-mobile PR: status-im/status-mobile#21931
status-desktop PR: status-im/status-desktop#17054
Summary