refactor(contacts): remove hack force refreshing images with a timestamp #17054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
micieslak,
caybro,
alexjba and
a team
as code owners
Jenkins BuildsClick to see older builds (14)
|
jrainville
force-pushed
the
refactor/contact-images-refresh
branch
from
f82f0c1 to
939f001
Compare
|
I tested the PR by updating the profile picture in one account and checking that the other account sees the new image everywhere. This looks good! 👍 |
jrainville
force-pushed
the
refactor/contact-images-refresh
branch
from
939f001 to
33628bf
Compare
|
I noticed an issue that may be related to this:
The profile pic looks good in the rest of the places. Edit: this is actually happening on a master build, and is unrelated to this PR, new issue created: #17089 cc @jrainville |
jrainville
force-pushed
the
refactor/contact-images-refresh
branch
from
33628bf to
9827de5
Compare
micieslak
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #16814
This gets rid of the uglu hack of adding
addTimestampToURLto each image.Now, the url coming from status-go contains the timestamp of when the image was updated. The status-go PR is here: status-im/status-go#6239
Affected areas
Contact list, member lists, user profile
Architecture compliance
My PR is consistent with this document: Status Desktop Architecture Guide
Screenshot of functionality
profile-image-change.webm
Impact on end user
Nothing. It should work as before. There is just less ugly code and in theory it would be a nonosecond faster
How to test
Risk
Tick one:
Worst case, some place the image doesn't update until a restart