chore(wallet-community)_: Move community minting airdrop to router #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (168)
|
|
Next step is to remove the code below and related functions, that should be on the wallet service to take care of transactions. 
|
saledjenic
changed the title
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
5 times, most recently
from
45dd4c2 to
00a5a5f
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
6 times, most recently
from
78f7468 to
2757af4
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
3 times, most recently
from
5c0877e to
8c002e3
Compare
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
3 times, most recently
from
559773a to
87cf27f
Compare
saledjenic
requested review from
a team,
iurimatias and
jrainville
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## move-community-minting-airdrop-to-router-pre-step-2 #6196 +/- ##
======================================================================================
Coverage ? 61.27%
======================================================================================
Files ? 856
Lines ? 112644
Branches ? 0
======================================================================================
Hits ? 69027
Misses ? 35648
Partials ? 7969
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
from
87cf27f to
3394343
Compare
|
Could you change the base to be on top of #6261, that way we don't have to review that commit twice. Thanks |
saledjenic
changed the base branch from
develop
to
move-community-minting-airdrop-to-router-pre-step-1
saledjenic
changed the base branch from
move-community-minting-airdrop-to-router-pre-step-1
to
move-community-minting-airdrop-to-router-pre-step-2
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router-pre-step-2
branch
from
3394343 to
37aeb40
Compare
…outer - new file `contracts/community-tokens/contracts.go` added to unify contracts creation - the following community related path processors added: - `CommunityBurnProcessor` - `CommunityDeployAssetsProcessor` - `CommunityDeployCollectiblesProcessor` - `CommunityDeployOwnerTokenProcessor` - `CommunityMintTokensProcessor` - `CommunityRemoteBurnProcessor` - `CommunitySetSignerPubKeyProcessor` - `SendType` extended with appropriate options - added endpoints to duplicated `communitytokens` api: - `StoreDeployedCollectibles` - `StoreDeployedOwnerToken` - `StoreDeployedAssets` - removed endpoints from duplicated `communitytokens` api: - `DeployCollectibles` - `DeployOwnerToken` - `ReTrackOwnerTokenDeploymentTransaction` - `DeployAssets` - `DeployCollectiblesEstimate` - `DeployAssetsEstimate` - `DeployOwnerTokenEstimate` - `EstimateMintTokens` - `EstimateRemoteBurn` - `EstimateBurn` - `EstimateSetSignerPubKey` - `NewOwnerTokenInstance` - `NewCommunityTokenDeployerInstance` - `NewCommunityOwnerTokenRegistryInstance` - `NewCollectiblesInstance` - `NewAssetsInstance` - `MintTokens` - `RemoteBurn` - `GetCollectiblesContractInstance` - `GetAssetContractInstance` - `Burn` - `SetSignerPubKey` - `Path` type extended with new property: - `UsedContractAddress` - an address of the contract that will be used for the transaction
saledjenic
force-pushed
the
move-community-minting-airdrop-to-router
branch
from
6dcc4bd to
d442b09
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the main PR in moving community-related transactions from
communitytokenstowalletservice and aligning the sending flow across the app.Related PRs:
Changes done in this PR:
new file
contracts/community-tokens/contracts.goadded to unify contracts creationthe following community related path processors added:
CommunityBurnProcessorCommunityDeployAssetsProcessorCommunityDeployCollectiblesProcessorCommunityDeployOwnerTokenProcessorCommunityMintTokensProcessorCommunityRemoteBurnProcessorCommunitySetSignerPubKeyProcessorSendTypeextended with appropriate optionsadded endpoints to duplicated
communitytokensAPI:StoreDeployedCollectiblesStoreDeployedOwnerTokenStoreDeployedAssetsremoved endpoints from duplicated
communitytokensAPI:DeployCollectiblesDeployOwnerTokenReTrackOwnerTokenDeploymentTransactionDeployAssetsDeployCollectiblesEstimateDeployAssetsEstimateDeployOwnerTokenEstimateEstimateMintTokensEstimateRemoteBurnEstimateBurnEstimateSetSignerPubKeyNewOwnerTokenInstanceNewCommunityTokenDeployerInstanceNewCommunityOwnerTokenRegistryInstanceNewCollectiblesInstanceNewAssetsInstanceMintTokensRemoteBurnGetCollectiblesContractInstanceGetAssetContractInstanceBurnSetSignerPubKeyPathtype extended with new property:UsedContractAddress- an address of the contract that will be used for the transaction