Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast Notifications for Wallet part 2: Community minting and airdropping and WC/BC #16810

Open
virginiabalducci opened this issue Nov 25, 2024 · 2 comments
Open

Toast Notifications for Wallet part 2: Community minting and airdropping and WC/BC #16810

virginiabalducci opened this issue Nov 25, 2024 · 2 comments
Labels
feature wallet-team
Milestone
2.33.0 Beta

Comments

@virginiabalducci
Copy link

Bug Report

Description

Follow up of #16732

we need to check/add:

  • notifications for WC/BC
  • notifications for Community minting and airdropping

User stories here:
https://www.notion.so/Notifications-improvements-13d8f96fb65c80389a6de884e029571d
@virginiabalducci virginiabalducci added bug Something isn't working wallet-team labels Nov 25, 2024
@virginiabalducci virginiabalducci added this to the 2.33.0 Beta milestone Nov 25, 2024
@virginiabalducci virginiabalducci mentioned this issue Nov 25, 2024
Merged
@virginiabalducci
Copy link
Author

cc @saledjenic for visibility

@anastasiyaig anastasiyaig added feature and removed bug Something isn't working labels Nov 27, 2024
saledjenic added a commit that referenced this issue Dec 24, 2024
@saledjenic
chore(communities-wallet): various improvements on community related …
02124c5 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
@saledjenic saledjenic mentioned this issue Dec 24, 2024
Merged
saledjenic added a commit that referenced this issue Dec 25, 2024
@saledjenic
chore(communities-wallet): various improvements on community related …
67acc70 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Dec 29, 2024
@saledjenic
chore(communities-wallet): various improvements on community related …
6cd4280 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Dec 31, 2024
@saledjenic
chore(communities-wallet): various improvements on community related …
fa6b1f5 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 8, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
963dda6 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 13, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
b37a3ee 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 14, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
a33044d 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 15, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
38d7d04 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 16, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
348bc1f 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 16, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
44797ba 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
@saledjenic
Copy link
Contributor

@virginiabalducci this couldn't be easily added to the code base we had. Because of that, we had to redo some things and bring community-related tx to the wallet transactions flow we already have in place. That approach provides better/easier maintaining in the future.

The following PRs cover this issue:

saledjenic added a commit that referenced this issue Jan 23, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
8abdb7b 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 24, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
184625c 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 27, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
043f08c 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
saledjenic added a commit that referenced this issue Jan 29, 2025
@saledjenic
chore(communities-wallet): various improvements on community related …
a4d4cfc 
…transaction flows

These changes should simplify the community related tx handlings on the client side, align it with
tx flows that we already have for other sending types and make it maintainable.

Related issue: #16810
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature wallet-team
Projects
Status Desktop/Mobile Board
Status: QA
Milestone
2.33.0 Beta
Development

No branches or pull requests
3 participants
@virginiabalducci @anastasiyaig @saledjenic