Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic support #2767

Merged
merged 47 commits into from
Aug 22, 2023
Merged

Noetic support #2767

merged 47 commits into from
Aug 22, 2023

Conversation

pazeshun
Copy link
Collaborator

@pazeshun pazeshun commented Aug 16, 2023

Updated version of #2761

@pazeshun pazeshun mentioned this pull request Aug 16, 2023
5 tasks
@pazeshun pazeshun force-pushed the noetic-rebased branch 2 times, most recently from dd0fdaa to 5eba455 Compare August 21, 2023 15:29
@pazeshun
Copy link
Collaborator Author

pazeshun commented Aug 22, 2023

Now I think what I can do in this PR is over.

  • GitHub Actions:
    • All tests including Noetic passed
  • Travis:
  • Docker Hub:
    • indigo-latest image was successfully built:
      https://hub.docker.com/repository/registry-1.docker.io/jskrobotics/jsk_apc/builds/6ed6e766-253c-4a05-ad74-c60140b8f010
      But other images cannot be built on pull request because we only have one Dockerfile. We have several build rules to generate other images, but they target master branch and I could not apply them to pull request.
      (Also, another troublesome point of pull request build on Docker Hub is that those who are not members of jskrobotics group on Docker Hub cannot see the build log. So I'll disable pull request build on Docker Hub again after this PR finishes.)

@knorth55 Could you briefly check this PR? Does this PR satisfy what you want to do in #2746 and #2761 ?

@knorth55
Copy link
Member

@pazeshun thanks! this PR satisfies what I wanted to do.

@pazeshun pazeshun merged commit 3f19db4 into start-jsk:master Aug 22, 2023
6 of 7 checks passed
@pazeshun pazeshun deleted the noetic-rebased branch August 22, 2023 10:40
@pazeshun pazeshun mentioned this pull request Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants