-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround genco
bug
#145
Workaround genco
bug
#145
Conversation
1080c53
to
afe1ff3
Compare
Looks like `genco = 0.17.7` from last month breaks compilation. This is a dependency of `cairo-lang-starknet`, which is why we need the cargo-udeps flag (it isn't used inside starknet-api at all).
afe1ff3
to
cb4f19b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @giladchase)
Cargo.toml
line 18 at r1 (raw file):
# TODO(Gilad): Remove `genco` dep once the issue with its 0.17.7 release # is fixed, or no longer a dependency of cairo-lang-starknet. genco = "=0.17.6"
Suggestion:
<=0.17.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @elintul)
Cargo.toml
line 18 at r1 (raw file):
# TODO(Gilad): Remove `genco` dep once the issue with its 0.17.7 release # is fixed, or no longer a dependency of cairo-lang-starknet. genco = "=0.17.6"
Doesn't seem to work, also < 0.17.7
, not sure why 🤔
Only =
seems to be strict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @elintul)
Cargo.toml
line 18 at r1 (raw file):
Previously, giladchase wrote…
Doesn't seem to work, also
< 0.17.7
, not sure why 🤔
Only=
seems to be strict
Can i merge it with =0.17.6
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
Looks like
genco = 0.17.7
from last month breaks compilation. This is a dependency ofcairo-lang-starknet
, which is why we need the cargo-udeps flag (it isn't used inside starknet-api at all).This change is