Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround genco bug #145

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Workaround genco bug #145

merged 1 commit into from
Nov 6, 2023

Conversation

giladchase
Copy link
Contributor

@giladchase giladchase commented Nov 6, 2023

Looks like genco = 0.17.7 from last month breaks compilation. This is a dependency of cairo-lang-starknet, which is why we need the cargo-udeps flag (it isn't used inside starknet-api at all).


This change is Reviewable

@giladchase giladchase force-pushed the gilad/fix-genco-dep branch 3 times, most recently from 1080c53 to afe1ff3 Compare November 6, 2023 12:07
Looks like `genco = 0.17.7` from last month breaks compilation.
This is a dependency of `cairo-lang-starknet`, which is why we need the
cargo-udeps flag (it isn't used inside starknet-api at all).
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @giladchase)


Cargo.toml line 18 at r1 (raw file):

# TODO(Gilad): Remove `genco` dep once the issue with its 0.17.7 release
# is fixed, or no longer a dependency of cairo-lang-starknet.
genco = "=0.17.6"

Suggestion:

<=0.17.6

Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @elintul)


Cargo.toml line 18 at r1 (raw file):

# TODO(Gilad): Remove `genco` dep once the issue with its 0.17.7 release
# is fixed, or no longer a dependency of cairo-lang-starknet.
genco = "=0.17.6"

Doesn't seem to work, also < 0.17.7, not sure why 🤔
Only = seems to be strict

Copy link
Contributor Author

@giladchase giladchase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware and @elintul)


Cargo.toml line 18 at r1 (raw file):

Previously, giladchase wrote…

Doesn't seem to work, also < 0.17.7, not sure why 🤔
Only = seems to be strict

Can i merge it with =0.17.6?

@giladchase giladchase added this pull request to the merge queue Nov 6, 2023
Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

Merged via the queue into main with commit 589e69d Nov 6, 2023
5 checks passed
@giladchase giladchase deleted the gilad/fix-genco-dep branch November 6, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants