Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Workaround genco bug (#145) #1089

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Workaround genco bug (#145) #1089

merged 1 commit into from
Nov 6, 2023

Conversation

giladchase
Copy link
Collaborator

@giladchase giladchase commented Nov 6, 2023

Looks like genco = 0.17.7 from last month breaks compilation. This didn't pop up yet because of our committed Cargo.lock, but since we publish blockifier as a lib-crate, it runs an update when we publish.

We had to do this on Starknet API here as well: starkware-libs/starknet-api#145


This change is Reviewable

Looks like `genco = 0.17.7` from last month breaks compilation.
This didn't pop up yet because of our committed Cargo.lock, but since we
publish `blockifier` as a lib-crate, it runs an `update` when we publish.
@codecov-commenter
Copy link

Codecov Report

Merging #1089 (10e2a82) into main (4478a79) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1089   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files          51       51           
  Lines        6494     6494           
  Branches     6494     6494           
=======================================
  Hits         4384     4384           
  Misses       1726     1726           
  Partials      384      384           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Collaborator

@elintul elintul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@giladchase giladchase merged commit 0a50932 into main Nov 6, 2023
10 checks passed
@giladchase giladchase deleted the gilad/genco-version-fix branch November 6, 2023 13:55
gswirski pushed a commit to reilabs/blockifier that referenced this pull request Jun 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants