feat: Total Confidence - functionality to send tracking events #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklasl
commented
Mar 20, 2024
…ider-java into evnt-generic
|
|
||
| public abstract com.google.protobuf.Value toProto(); | ||
|
|
||
| public static class StringValue extends ConfidenceValue { |
There was a problem hiding this comment.
This one differs by having the Value suffix in it's name. But I think that makes sense. Having these primitive types being public and sharing so many names with standard Java types will be a mess for developers? We should have a common naming scheme though.
There was a problem hiding this comment.
Would also be solved by only modeling a Primitive..
There was a problem hiding this comment.
I'll take a stab at this.
src/main/java/com/spotify/confidence/ConfidenceFeatureProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/com/spotify/confidence/FlagResolverClientImpl.java
Outdated
Show resolved
Hide resolved
| private final String clientSecret; | ||
|
|
||
| private final String SDK_VERSION; | ||
| private static final SdkId SDK_ID = SdkId.SDK_ID_JAVA_PROVIDER; |
There was a problem hiding this comment.
Add a new SDK_ID to proto. SDK_ID_JAVA_CONFIDENCE
* context inheritence and closing WIP * don't throw for closed send() + tests * mark GrpcEventUploader constructor as package private --------- Co-authored-by: Andreas Karlsson <[email protected]>
…t for flag resolver grpc context flattening
vahidlazio
force-pushed
the
evnt-generic
branch
from
bd74d90
to
14ce138
Compare
…add test for flag resolver grpc context flattening
Closed
nicklasl
commented
Mar 25, 2024
…lient, add test for flag resolver grpc context flattening
vahidlazio
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main part of this functionality lies in the new way of constructing the Provider, by using
Confidence.builder(..)and passing yourConfidenceinstance as a constructor param for the OF Provider you can also use theConfidenceobject to emit tracking events!Release-As: 0.1.0