docs: Events in README #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider-java into evnt-generic
* context inheritence and closing WIP * don't throw for closed send() + tests * mark GrpcEventUploader constructor as package private --------- Co-authored-by: Andreas Karlsson <[email protected]>
fabriziodemaria
force-pushed
the
evnt-generic-readme
branch
from
564ec9a
to
072030d
Compare
fabriziodemaria
force-pushed
the
evnt-generic-readme
branch
from
072030d
to
783fd73
Compare
nickybondarenko
approved these changes
Mar 25, 2024
nicklasl
reviewed
Mar 25, 2024
Co-authored-by: Nicklas Lundin <[email protected]>
Co-authored-by: Nicklas Lundin <[email protected]>
Co-authored-by: Nicklas Lundin <[email protected]>
nicklasl
approved these changes
Mar 25, 2024
README.md
Outdated
| final Confidence confidenceWithContext = confidence.withContext(ConfidenceValue.of("context-value")); | ||
| confidenceWithContext.send("my-event", ConfidenceValue.of("event-value")); | ||
| ``` | ||
| The "my-event" event in the example above will contain fields for "event-value", "context-value" and the Evaluation Context data set via `OpenFeatureAPI.getInstance().setEvaluationContext(...)`. |
There was a problem hiding this comment.
nit:
Suggested change
| The "my-event" event in the example above will contain fields for "event-value", "context-value" and the Evaluation Context data set via `OpenFeatureAPI.getInstance().setEvaluationContext(...)`. | |
| The "my-event" event in the example above will contain fields for "event-value", "context-value" and the Evaluation Context data set via `OpenFeatureAPI.getInstance().setEvaluationContext(...)`. | |
| We suggest you you this `withContext()`-API to send events which are "request context" based events as well. | |
There was a problem hiding this comment.
We suggest you you this
withContext()-API to send events which are "request context" based events as well.
Can you re-phrase slightly or explain here what you mean?
fabriziodemaria
force-pushed
the
evnt-generic-readme
branch
from
9865407
to
cf4cc03
Compare
fabriziodemaria
force-pushed
the
evnt-generic-readme
branch
from
cf4cc03
to
b965755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WAIT ON RELEASE: #88