Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature: Support AWS with Cilium #1396

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add feature: Support AWS with Cilium #1396

merged 2 commits into from
Aug 1, 2024

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Jul 22, 2024

Issue

For: #1358

Changes

  • Accpect traffic in PREROUTING, to avoid cilium hijack traffic.
  • Clean code

Doc

  • Doc

@lou-lan lou-lan force-pushed the feature/aws branch 2 times, most recently from df66709 to 61eae52 Compare July 22, 2024 09:53
@lou-lan lou-lan added the release/feature-new feature pr recoded in new release label Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 12 lines in your changes missing coverage. Please review.

Project coverage is 82.96%. Comparing base (8390880) to head (3e42709).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/agent/route/route.go 66.66% 7 Missing and 1 partial ⚠️
pkg/controller/tunnel/egress_tunnel.go 75.00% 0 Missing and 2 partials ⚠️
pkg/utils/flat.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1396      +/-   ##
==========================================
- Coverage   85.46%   82.96%   -2.51%     
==========================================
  Files          20       19       -1     
  Lines        2560     2278     -282     
==========================================
- Hits         2188     1890     -298     
- Misses        265      277      +12     
- Partials      107      111       +4     
Flag Coverage Δ
unittests 82.96% <86.66%> (-2.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/agent/vxlan/vxlan.go 97.39% <100.00%> (-1.05%) ⬇️
pkg/controller/endpoint/cluster_endpoint_slice.go 98.63% <100.00%> (-0.66%) ⬇️
pkg/controller/endpoint/endpoint_slice.go 98.58% <100.00%> (-1.42%) ⬇️
pkg/utils/list.go 100.00% <100.00%> (ø)
pkg/controller/tunnel/egress_tunnel.go 44.20% <75.00%> (+0.53%) ⬆️
pkg/utils/flat.go 92.00% <0.00%> (-8.00%) ⬇️
pkg/agent/route/route.go 93.49% <66.66%> (-6.51%) ⬇️

... and 1 file with indirect coverage changes

@weizhoublue weizhoublue temporarily deployed to commit July 22, 2024 12:38 Inactive
@weizhoublue
Copy link
Collaborator

weizhoublue commented Jul 22, 2024

@weizhoublue weizhoublue temporarily deployed to pull request July 22, 2024 12:38 Inactive
@weizhoublue
Copy link
Collaborator

@weizhoublue
Copy link
Collaborator

weizhoublue commented Jul 23, 2024

需要在 PR 描述中,说明 为 cilium 做了 什么适配(),以后方便 review,或者 cilium 版本 迭代了,好回溯改进

@weizhoublue
Copy link
Collaborator

weizhoublue commented Jul 23, 2024

相关文档 需要说明 适配了 cilium 什么版本 或者 安装要求 ? 否则,我 有可能 一些 cilium 老版本 或者 安装方式 会出问题

@weizhoublue
Copy link
Collaborator

缺少 ciilum 场景的 E2E

@weizhoublue
Copy link
Collaborator

https://spidernet-io.github.io/egressgateway/v0.5/usage/Install/

这个文档也,添加 裸金属场景下 cilium 的场景

@lou-lan
Copy link
Collaborator Author

lou-lan commented Jul 23, 2024

缺少 ciilum 场景的 E2E

是的,我看下 kind 能模拟吗

@lou-lan
Copy link
Collaborator Author

lou-lan commented Jul 23, 2024

相关文档 需要说明 适配了 cilium 什么版本 或者 安装要求 ? 否则,我 有可能 一些 cilium 老版本 或者 安装方式 会出问题

在文章中澄清了,使用的 Cilium 版本。

@weizhoublue weizhoublue temporarily deployed to commit July 31, 2024 09:02 Inactive
@weizhoublue weizhoublue temporarily deployed to pull request July 31, 2024 09:02 Inactive
@weizhoublue weizhoublue temporarily deployed to commit July 31, 2024 09:08 Inactive
@weizhoublue weizhoublue temporarily deployed to pull request July 31, 2024 09:08 Inactive
@weizhoublue weizhoublue temporarily deployed to commit July 31, 2024 10:10 Inactive
@weizhoublue weizhoublue temporarily deployed to pull request July 31, 2024 10:10 Inactive
@weizhoublue weizhoublue temporarily deployed to commit July 31, 2024 11:15 Inactive
@weizhoublue weizhoublue temporarily deployed to pull request July 31, 2024 11:16 Inactive
@lou-lan
Copy link
Collaborator Author

lou-lan commented Jul 31, 2024

缺少 ciilum 场景的 E2E

是的,我看下 kind 能模拟吗

New github CI test has pass in https://github.com/spidernet-io/egressgateway/actions/runs/10178278346

@weizhoublue weizhoublue temporarily deployed to pull request July 31, 2024 11:44 Inactive
@weizhoublue weizhoublue temporarily deployed to commit July 31, 2024 11:44 Inactive
@weizhoublue weizhoublue temporarily deployed to commit July 31, 2024 11:49 Inactive
@weizhoublue weizhoublue temporarily deployed to pull request July 31, 2024 11:49 Inactive
@weizhoublue weizhoublue temporarily deployed to commit July 31, 2024 11:55 Inactive
@weizhoublue weizhoublue temporarily deployed to pull request July 31, 2024 11:55 Inactive
@weizhoublue weizhoublue merged commit ab8cbd4 into main Aug 1, 2024
37 checks passed
@weizhoublue weizhoublue deleted the feature/aws branch August 1, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/feature-new feature pr recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants