Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : spec.EgressIP in egressgateway does not take effect #1410

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

lou-lan
Copy link
Collaborator

@lou-lan lou-lan commented Jul 27, 2024

Fix #1404

merge in #1396
this pr will close.

@lou-lan lou-lan added the release/bug bug pr recoded in new release label Jul 27, 2024
@lou-lan lou-lan force-pushed the fix-assign-ip branch 4 times, most recently from 8aea605 to c653ffa Compare July 28, 2024 17:47
@weizhoublue
Copy link
Collaborator

需要 用例 闭环

@lou-lan
Copy link
Collaborator Author

lou-lan commented Jul 29, 2024

需要 用例 闭环

P00010 P00022

@lou-lan lou-lan force-pushed the fix-assign-ip branch 7 times, most recently from 58f13a8 to 42a5dd4 Compare July 29, 2024 03:33
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 93.84615% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.23%. Comparing base (8390880) to head (c39e413).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/controller/tunnel/egress_tunnel.go 75.00% 0 Missing and 2 partials ⚠️
pkg/utils/flat.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1410      +/-   ##
==========================================
- Coverage   85.46%   83.23%   -2.24%     
==========================================
  Files          20       19       -1     
  Lines        2560     2266     -294     
==========================================
- Hits         2188     1886     -302     
- Misses        265      270       +5     
- Partials      107      110       +3     
Flag Coverage Δ
unittests 83.23% <93.84%> (-2.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/controller/endpoint/cluster_endpoint_slice.go 98.63% <100.00%> (-0.66%) ⬇️
pkg/controller/endpoint/endpoint_slice.go 98.58% <100.00%> (-1.42%) ⬇️
pkg/utils/list.go 100.00% <100.00%> (ø)
pkg/controller/tunnel/egress_tunnel.go 44.20% <75.00%> (+0.53%) ⬆️
pkg/utils/flat.go 92.00% <0.00%> (-8.00%) ⬇️

... and 2 files with indirect coverage changes

@lou-lan lou-lan force-pushed the fix-assign-ip branch 13 times, most recently from 6504977 to ba12f26 Compare July 29, 2024 11:46
@lou-lan lou-lan force-pushed the fix-assign-ip branch 5 times, most recently from fff850e to e3f5acf Compare July 29, 2024 17:00
@weizhoublue weizhoublue changed the title Fix assign IP not use spec.EgressIP Fix : spec.EgressIP in egressgateway does not take effect Jul 30, 2024
@lou-lan lou-lan force-pushed the fix-assign-ip branch 15 times, most recently from 4c58418 to 7a2c5aa Compare July 31, 2024 02:25
@lou-lan lou-lan added the pr/not-ready not ready for merging label Jul 31, 2024
@weizhoublue weizhoublue merged commit c39e413 into main Aug 1, 2024
32 of 33 checks passed
@weizhoublue weizhoublue deleted the fix-assign-ip branch August 1, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/not-ready not ready for merging release/bug bug pr recoded in new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ignore defined EgressPolicy ipv4
2 participants