-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix : spec.EgressIP in egressgateway does not take effect #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lou-lan
force-pushed
the
fix-assign-ip
branch
4 times, most recently
from
July 28, 2024 17:47
8aea605
to
c653ffa
Compare
需要 用例 闭环 |
P00010 P00022 |
lou-lan
force-pushed
the
fix-assign-ip
branch
7 times, most recently
from
July 29, 2024 03:33
58f13a8
to
42a5dd4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 85.46% 83.23% -2.24%
==========================================
Files 20 19 -1
Lines 2560 2266 -294
==========================================
- Hits 2188 1886 -302
- Misses 265 270 +5
- Partials 107 110 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lou-lan
force-pushed
the
fix-assign-ip
branch
13 times, most recently
from
July 29, 2024 11:46
6504977
to
ba12f26
Compare
lou-lan
force-pushed
the
fix-assign-ip
branch
5 times, most recently
from
July 29, 2024 17:00
fff850e
to
e3f5acf
Compare
weizhoublue
changed the title
Fix assign IP not use spec.EgressIP
Fix : spec.EgressIP in egressgateway does not take effect
Jul 30, 2024
lou-lan
force-pushed
the
fix-assign-ip
branch
15 times, most recently
from
July 31, 2024 02:25
4c58418
to
7a2c5aa
Compare
Signed-off-by: lou-lan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1404
merge in #1396
this pr will close.