Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix p4orch tests after SAI update #3337

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Fix p4orch tests after SAI update #3337

merged 4 commits into from
Oct 22, 2024

Commits on Oct 22, 2024

  1. Make sure p4orch tests always run, not just when gcov is enabled 

    Signed-off-by: Saikrishna Arcot <[email protected]>
    @saiarcot895
    saiarcot895 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0639f88 View commit details
    Browse the repository at this point in the history

  2. Update JSON fields in p4orch for latest SAI 

    Signed-off-by: Saikrishna Arcot <[email protected]>
    @saiarcot895
    saiarcot895 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f014d65 View commit details
    Browse the repository at this point in the history

  3. Disable the disabled-optimization for 2 ACL Manager tests in p4orch 

    2 test functions in acl_manager_test.cpp for p4orch are near 400 lines,
with macro expansion almost certainly adding a number of lines. On armhf
and arm64, GCC is complaining that it ran out of memory to do
optimizations here (specifically, keep track of const and copies).

```
error: const/copy propagation disabled: 9401 basic blocks and 114813 registers; increase '--param max-gcse-memory' above 134923152 [-Werror=disabled-optimization]
```

For now, turn the error into a warning for these two functions. Ideally,
these two test cases should be split up.

Signed-off-by: Saikrishna Arcot <[email protected]>
    @saiarcot895
    saiarcot895 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    e7bb63a View commit details
    Browse the repository at this point in the history

  4. Don't compile separate versions of p4orch_tests for ASAN/TSAN/UBSAN 

    Instead of manually compiling separate versions of p4orch_tests for
ASAN/TSAN/UBSAN, have it instead be controlled by the top-level
--asan-enabled configuration flag. This matches the behavior for all
other tests in this repo.

This fixes an issue where armhf TSAN is not available, and arm64 TSAN is
not supported (it results in an error on startup).

Signed-off-by: Saikrishna Arcot <[email protected]>
    @saiarcot895
    saiarcot895 committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    2981db7 View commit details
    Browse the repository at this point in the history