Fix p4orch tests after SAI update #3337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
force-pushed
the
fix-p4orch-tests
branch
from
4e973a9
to
f014d65
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Oct 22, 2024
2 test functions in acl_manager_test.cpp for p4orch are near 400 lines, with macro expansion almost certainly adding a number of lines. On armhf and arm64, GCC is complaining that it ran out of memory to do optimizations here (specifically, keep track of const and copies). ``` error: const/copy propagation disabled: 9401 basic blocks and 114813 registers; increase '--param max-gcse-memory' above 134923152 [-Werror=disabled-optimization] ``` For now, turn the error into a warning for these two functions. Ideally, these two test cases should be split up. Signed-off-by: Saikrishna Arcot <[email protected]>
prsunny
previously approved these changes
Oct 22, 2024
Instead of manually compiling separate versions of p4orch_tests for ASAN/TSAN/UBSAN, have it instead be controlled by the top-level --asan-enabled configuration flag. This matches the behavior for all other tests in this repo. This fixes an issue where armhf TSAN is not available, and arm64 TSAN is not supported (it results in an error on startup). Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Make sure that the p4orch tests are always run (not just when code coverage is enabled), and fix the p4orch tests following the SAI update.
Why I did it
sonic-net/sonic-sairedis#1431 updated the SAI submodule to the latest version, and #3321 fixed some of the compatibility issues, but there were still some that got through, because p4orch tests are enabled only when code coverage is enabled.
How I verified it
Details if related