Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip some test_generic_hash cases for Broadcom platforms #16530

Merged

Conversation

ZhaohuiS
Copy link
Contributor

@ZhaohuiS ZhaohuiS commented Jan 15, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

Now test_conditional_mark uses the longest match mechanism to search the matched scripts/cases.
In mark file, hash/test_generic_hash.py::test_lag_member_flap[CRC-INNER_IP_PROTOCOL is longer than hash/test_generic_hash.py::test_lag_member_flap, so even on Broadcom testbed, it will still run test_ecmp_and_lag_hash[CRC_CCITT-INNER_IP_PROTOCOL-ipv4-ipv6-vxlan], which should be skipped actually.

How did you do it?

Add Broadcom asic type for those longer cases, to make sure those test_generic_hash cases should be skipped on broadcom platforms.

How did you verify/test it?

Run test_generic_hash on broadcom testbed.

plugins: metadata-3.1.1, allure-pytest-2.8.22, forked-1.6.0, repeat-0.9.3, html-4.1.1, ansible-4.0.0, xdist-1.28.0
collected 10 items                                                                                                                                                                                                          

hash/test_generic_hash.py::test_hash_capability XFAIL (This is a new test cases and doesn't work for platform other than Mellanox, xfail them before the issue is addressed)                                          [ 10%]
hash/test_generic_hash.py::test_ecmp_hash[CRC_CCITT-INNER_DST_IP-ipv4-ipv6-ipinip] SKIPPED (ECMP hash not supported in broadcom SAI)                                                                                  [ 20%]
hash/test_generic_hash.py::test_lag_hash[CRC-SRC_IP-ipv6-None-None] SKIPPED (LAG hash not supported in broadcom SAI)                                                                                                  [ 30%]
hash/test_generic_hash.py::test_ecmp_and_lag_hash[CRC-INNER_SRC_IP-ipv6-ipv6-ipinip] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, ECMP/LAG ...) [ 40%]
hash/test_generic_hash.py::test_nexthop_flap[CRC-SRC_IP-ipv6-None-None] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, ECMP/LAG hash not supp...) [ 50%]
hash/test_generic_hash.py::test_lag_member_flap[CRC_CCITT-INNER_ETHERTYPE-ipv4-None-nvgre] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, LAG...) [ 60%]
hash/test_generic_hash.py::test_lag_member_remove_add[CRC-ETHERTYPE-ipv6-None-None] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, LAG hash n...) [ 70%]
hash/test_generic_hash.py::test_reboot[CRC_CCITT-INNER_SRC_MAC-ipv6-ipv6-vxlan-warm] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, ECMP/LAG ...) [ 80%]
hash/test_generic_hash.py::test_backend_error_messages XFAIL (This is a new test cases and doesn't work for platform other than Mellanox, xfail them before the issue is addressed)                                   [ 90%]
hash/test_generic_hash.py::test_algorithm_config XFAIL (This is a new test cases and doesn't work for platform other than Mellanox, xfail them before the issue is addressed)                                         [100%]

===================================================================================================== warnings summary ======================================================================================================
.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ZhaohuiS ZhaohuiS requested a review from StormLiangMS January 15, 2025 14:38
Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 0ee1e60 into sonic-net:master Jan 16, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants