Skip some test_generic_hash cases for Broadcom platforms #16530
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Now test_conditional_mark uses the longest match mechanism to search the matched scripts/cases.
In mark file,
hash/test_generic_hash.py::test_lag_member_flap[CRC-INNER_IP_PROTOCOL
is longer thanhash/test_generic_hash.py::test_lag_member_flap
, so even on Broadcom testbed, it will still runtest_ecmp_and_lag_hash[CRC_CCITT-INNER_IP_PROTOCOL-ipv4-ipv6-vxlan]
, which should be skipped actually.How did you do it?
Add Broadcom asic type for those longer cases, to make sure those test_generic_hash cases should be skipped on broadcom platforms.
How did you verify/test it?
Run test_generic_hash on broadcom testbed.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation