Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Skip some test_generic_hash for broadcom platforms (#16530)
What is the motivation for this PR? Now test_conditional_mark uses the longest match mechanism to search the matched scripts/cases. In mark file, hash/test_generic_hash.py::test_lag_member_flap[CRC-INNER_IP_PROTOCOL is longer than hash/test_generic_hash.py::test_lag_member_flap, so even on Broadcom testbed, it will still run test_ecmp_and_lag_hash[CRC_CCITT-INNER_IP_PROTOCOL-ipv4-ipv6-vxlan], which should be skipped actually. How did you do it? Add Broadcom asic type for those longer cases, to make sure those test_generic_hash cases should be skipped on broadcom platforms. How did you verify/test it? Run test_generic_hash on broadcom testbed. plugins: metadata-3.1.1, allure-pytest-2.8.22, forked-1.6.0, repeat-0.9.3, html-4.1.1, ansible-4.0.0, xdist-1.28.0 collected 10 items hash/test_generic_hash.py::test_hash_capability XFAIL (This is a new test cases and doesn't work for platform other than Mellanox, xfail them before the issue is addressed) [ 10%] hash/test_generic_hash.py::test_ecmp_hash[CRC_CCITT-INNER_DST_IP-ipv4-ipv6-ipinip] SKIPPED (ECMP hash not supported in broadcom SAI) [ 20%] hash/test_generic_hash.py::test_lag_hash[CRC-SRC_IP-ipv6-None-None] SKIPPED (LAG hash not supported in broadcom SAI) [ 30%] hash/test_generic_hash.py::test_ecmp_and_lag_hash[CRC-INNER_SRC_IP-ipv6-ipv6-ipinip] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, ECMP/LAG ...) [ 40%] hash/test_generic_hash.py::test_nexthop_flap[CRC-SRC_IP-ipv6-None-None] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, ECMP/LAG hash not supp...) [ 50%] hash/test_generic_hash.py::test_lag_member_flap[CRC_CCITT-INNER_ETHERTYPE-ipv4-None-nvgre] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, LAG...) [ 60%] hash/test_generic_hash.py::test_lag_member_remove_add[CRC-ETHERTYPE-ipv6-None-None] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, LAG hash n...) [ 70%] hash/test_generic_hash.py::test_reboot[CRC_CCITT-INNER_SRC_MAC-ipv6-ipv6-vxlan-warm] SKIPPED (On Mellanox SPC1 platforms, due to HW limitation, it would not support CRC_CCITT algorithm. For broadcom, ECMP/LAG ...) [ 80%] hash/test_generic_hash.py::test_backend_error_messages XFAIL (This is a new test cases and doesn't work for platform other than Mellanox, xfail them before the issue is addressed) [ 90%] hash/test_generic_hash.py::test_algorithm_config XFAIL (This is a new test cases and doesn't work for platform other than Mellanox, xfail them before the issue is addressed) [100%] ===================================================================================================== warnings summary ====================================================================================================== . Any platform specific information?
- Loading branch information