Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mass,MechanicalLoad] Use enumeration to clarify the code #4918

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

[Mass,MechanicalLoad] Use enumeration to clarify the code #4918

wants to merge 33 commits into from

Commits on Apr 22, 2024

  1. [Mass] Replace doUpdateInternal by callback: UniformMass

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8daef1a View commit details
    Browse the repository at this point in the history

  2. fix initial view in example scene using InteractiveCamera

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    96908f7 View commit details
    Browse the repository at this point in the history

  3. add call to componentState in accFromF and buildMassMatrix

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a0be3f2 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    572579a View commit details
    Browse the repository at this point in the history

  5. Use function isComponentStateValid

    @alxbilger @fredroy
    alxbilger authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    afd56eb View commit details
    Browse the repository at this point in the history

  6. remove empty override

    @alxbilger @fredroy
    alxbilger authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a700c53 View commit details
    Browse the repository at this point in the history

  7. Fix typo in comment

    @alxbilger @fredroy
    alxbilger authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c55918f View commit details
    Browse the repository at this point in the history

  8. remove useless comment

    @alxbilger @fredroy
    alxbilger authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    bdcfe71 View commit details
    Browse the repository at this point in the history

  9. take reviews into account: separate callbacks, add boolean switch

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9efc3ff View commit details
    Browse the repository at this point in the history

  10. minor clean

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    a56d0ea View commit details
    Browse the repository at this point in the history

  11. additional changes in UniformMass

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8cd9231 View commit details
    Browse the repository at this point in the history

  12. update associated test

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    23ffce1 View commit details
    Browse the repository at this point in the history

  13. Work on init and callback to get a clean state after init, fix test

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0126565 View commit details
    Browse the repository at this point in the history

  14. Fix tests attempt 1

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    01955c4 View commit details
    Browse the repository at this point in the history

  15. fix createRegularGridScene using UniformMass

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3e2c984 View commit details
    Browse the repository at this point in the history

  16. fix scene without specifying a mass

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    102aeaa View commit details
    Browse the repository at this point in the history

  17. Remove uses of mass data replaced with vertexMass

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    4301271 View commit details
    Browse the repository at this point in the history

  18. Update Sofa/Component/Mass/src/sofa/component/mass/UniformMass.inl

    @hugtalbot @fredroy
    hugtalbot authored and fredroy committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b20193f View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. merge with master 20240812

    @hugtalbot
    hugtalbot committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    cc557ed View commit details
    Browse the repository at this point in the history

  2. minor change on ConstantFF comment and config.h.in

    @hugtalbot
    hugtalbot committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f6ff564 View commit details
    Browse the repository at this point in the history

  3. remove reinit, add comments and fix typo in UM

    @hugtalbot
    hugtalbot committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    f72c957 View commit details
    Browse the repository at this point in the history

  4. simplify code regarding SingleStateAccessor

    @hugtalbot
    hugtalbot committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    e4fc67f View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. [Mass,MechanicalLoad] Use enumeration to clarify the code

    @hugtalbot
    hugtalbot committed Aug 13, 2024
    5 Configuration menu
    Copy the full SHA
    3b1cc06 View commit details
    Browse the repository at this point in the history

  2. use enum class, taking reviews into account

    @hugtalbot
    hugtalbot committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a90bbfd View commit details
    Browse the repository at this point in the history

  3. fit reviewer expected format

    @hugtalbot
    hugtalbot committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    12f327c View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Frederick Roy <[email protected]>
    @hugtalbot @fredroy
    hugtalbot and fredroy authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d50af0c View commit details
    Browse the repository at this point in the history

  5. Remove call to component state to prevent triggering callbacks

    @hugtalbot
    hugtalbot committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    b7c7293 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Fix test

    @hugtalbot
    hugtalbot committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    eb53a8d View commit details
    Browse the repository at this point in the history

  2. merge with sofa-framework#3927

    @hugtalbot
    hugtalbot committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    077a0b4 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into 202408_generalize_enumeration

    @hugtalbot
    hugtalbot authored Aug 14, 2024
    Configuration menu
    Copy the full SHA
    9371ffc View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2024

  1. Merge branch 'master' into 202408_generalize_enumeration

    @fredroy
    fredroy authored Aug 19, 2024
    Configuration menu
    Copy the full SHA
    7a86d8c View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. Remove default instantiation in class declaration

    @bakpaul
    bakpaul committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    d56029b View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2024

  1. Merge branch 'master' into 202408_generalize_enumeration

    @bakpaul
    bakpaul authored Aug 26, 2024
    Configuration menu
    Copy the full SHA
    8174abb View commit details
    Browse the repository at this point in the history