-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mass,MechanicalLoad] Use enumeration to clarify the code #4918
base: master
Are you sure you want to change the base?
[Mass,MechanicalLoad] Use enumeration to clarify the code #4918
Conversation
[ci-build][with-all-tests] |
Sofa/Component/MechanicalLoad/src/sofa/component/mechanicalload/ConstantForceField.h
Outdated
Show resolved
Hide resolved
[ci-build][with-all-tests][force-full-build] |
/// Trigger callbacks to update data (see constructor) | ||
if(!this->isComponentStateValid()) | ||
msg_error() << "Initialization process is invalid"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#4917 has been integrated (not rebased due to anterior conflicts) and there are still errors because of I guess there is an error of logics (if, else, etc) somewhere |
Based on #3927
Needs #4917 to make all tests pass successfully.
This PR aims at :
Diff : hugtalbot/sofa@b7c7293...hugtalbot:9371ffc1731840b2d100eb7deaa754775c98c6c7
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if