feat: allow proposal creation only on premium networks #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wa0x6e
force-pushed
the
feat-allow-proposal-creation-only-on-premium-networks
branch
from
1bf3090 to
435f21b
Compare
bonustrack
reviewed
Jan 24, 2025
| > | ||
| <div> | ||
| You cannot create proposals. | ||
| <br /> |
There was a problem hiding this comment.
We dont need a new line here
| <br /> | ||
| The space is configured with | ||
| <b>{{ unsupportedProposalNetworks[0].name }}</b> | ||
| , a non-premium network. Change to a premium network or upgrade |
There was a problem hiding this comment.
There shouldn't be a space between the network name and the ","
ChaituVR
reviewed
Jan 24, 2025
Comment on lines
+163
to
+167
| export const PROPOSALS_NETWORK_WHITELIST: ChainId[] = [ | ||
| 1, //Ethereum | ||
| 42161, // Arbitrum | ||
| 137 // Polygon | ||
| ]; |
There was a problem hiding this comment.
maybe we should add a param premium or subscribed on networks.json instead of a separate list?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/389
This PR blocks the proposal creation on offchain spaces using non-premium networks
The message error should superseed all other messages (like voting validation, etc ...)
How to test
TODO