-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: expect correct google cloud storage abbreviation in query scheme (gcs://) #39
Conversation
🤖 I have created a release *beep* *boop* --- ## [1.0.0](v0.1.4...v1.0.0) (2024-04-26) ### ⚠ BREAKING CHANGES * expect correct google cloud storage abbreviation in query scheme (gcs://) ([#39](#39)) ### Bug Fixes * expect correct google cloud storage abbreviation in query scheme (gcs://) ([#39](#39)) ([0ebf52c](0ebf52c)) * fix directory support ([#38](#38)) ([ce3d165](ce3d165)) ### Documentation * add intro, fix link ([6ec568a](6ec568a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Just following up on this @johanneskoester - has this change been tested on a bucket? As far as I'm seeing this change breaks the plugin due to the |
We changed the scheme to gcs:// because that is consistent with the plugin name (snakemake-storage-plugin-gcs). At the time of naming, I had the impression that the abbreviation gcs is more commonly used than gs (and also more specific). The plugin does not use gcs:// as a prefix for any query internally, it just takes that as a user input and infers bucket and key and from the url. Hence, I cannot see how the prefix change could cause problems. The only thing I can imagine is that it does not work to copy-pasted back an forth with google tools that eventually expect |
Thinking about it, it does not hurt to support both while internally normalizing to gs:// so that even passing on to google tools should always work as expected. Does that help? #52 |
@johanneskoester This will be incredibly helpful, yes. Thank you! |
Ok, released! Thank you! |
I am sorry for the breaking change. This is unavoidable unfortunately, in order to have a consistent experience. GCS seems to be the official abbreviation of google cloud storage.