Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename to -plugin-gs? #37

Closed
vsoch opened this issue Apr 25, 2024 · 4 comments
Closed

rename to -plugin-gs? #37

vsoch opened this issue Apr 25, 2024 · 4 comments

Comments

@vsoch
Copy link
Collaborator

vsoch commented Apr 25, 2024

@johanneskoester there is a bit of confusion about if the plugin is gs or gcs - that of course advises the prefix. If it is gs should we rename to that?

@johanneskoester
Copy link
Contributor

It is gcs. I think that is the more official abbreviation of google cloud storage, therefore I changed the name.

@johanneskoester
Copy link
Contributor

Closing, feel free to open or email me if I am missing something.

@johanneskoester
Copy link
Contributor

Ah, now I see, there was still expected the old gs:// scheme in the query. My fault. I made a PR with a corresponding breaking change. Hopefully this is still early enough so that not too many people will be upset by such a breaking change.

#39

@vsoch
Copy link
Collaborator Author

vsoch commented Apr 26, 2024

See snakemake/snakemake-executor-plugin-googlebatch#50: still having trouble with default snakemake flags and plugins installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants