feat: will reject jobs, which attempt setting job names by 'slurm_extra' #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't think the change is so severe. Please let me know what you think. |
fgvieira
reviewed
Jun 4, 2024
fgvieira
approved these changes
Jun 4, 2024
|
Yeah, hard to make a testcase but changes not too drastic. Looks good! |
fix: grammar and emphasis Co-authored-by: Filipe G. Vieira <[email protected]>
cmeesters
pushed a commit
that referenced
this pull request
Jun 7, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.2...v0.6.0) (2024-06-07) ### Features * will reject jobs, which attempt setting job names by 'slurm_extra' ([#93](#93)) ([df2fd3d](df2fd3d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cmeesters
pushed a commit
that referenced
this pull request
Jul 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.6.0](v0.5.2...v0.6.0) (2024-06-07) ### Features * will reject jobs, which attempt setting job names by 'slurm_extra' ([#93](#93)) ([df2fd3d](df2fd3d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasionally, users reported that their attempt to overwrite SLURM job names leads to faulty behaviour (job status does not get queried properly, and a workflow will stall). This is understandable from the code and documented accordingly.
The PR checks for the job status using a regex - simple string matching might be too error-prone (e.g. "-J" can be part of a wildcard).
The decision is here, that the workflow will abort (raising WorkflowError and explaining and pointing to the docs).
Please check whether this is "likeable".
I do not know how to implement a test. The other executors leave me clueless.