Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] new e-email text #52

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

jehofmann
Copy link
Contributor

Add a new line in email to notify about outdated Internet Explorer.

@beatrycze-volk beatrycze-volk added the enhancement New feature or request label Jan 23, 2025
@@ -401,6 +401,10 @@
<source><![CDATA[Wenn Sie die Registrierung auf der Website nicht selbst vorgenommen haben, können Sie diese E-Mail ignorieren.]]></source>
<target><![CDATA[Wenn Sie die Registrierung auf der Website nicht selbst vorgenommen haben, können Sie diese E-Mail ignorieren.]]></target>
</trans-unit>
<trans-unit id="emailCreateUserConfirmationText5" approved="yes">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only those two? DIGAS works also with Chrome and probably most of the webrowsers. Maybe message should be something like:

<![CDATA[Bei Verwendung des Internet Explorers als Standardbrowser kann es zu Problem kommen. Ist dies der Fall, ändern Sie bitte Webbrowser auf zB. Google Chrome, Microsoft Edge oder Mozilla Firefox, dann nutzen Sie bitte die Passwort-Vergessen-Funktion auf der DiGA.Sax Webseite.]]>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requirement and wording was given directly by the LfULG. It is only important to say that IE is no longer supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then leave it as it is :)

@@ -290,6 +290,9 @@
<trans-unit id="emailCreateUserConfirmationText4">
<source><![CDATA[Wenn Sie die Registrierung auf der Website nicht selbst vorgenommen haben, können Sie diese E-Mail ignorieren.]]></source>
</trans-unit>
<trans-unit id="emailCreateUserConfirmationText5">
<source><![CDATA[Bitte verwenden Sie als Standardbrowser Microsoft Edge oder Mozilla Firefox. Bei Verwendung des Internet Explorers als Standardbrowser kann es zu Problem kommen. Ist dies der Fall, dann nutzen Sie bitte die Passwort-Vergessen-Funktion auf der DiGA.Sax Webseite.]]></source>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source message should be in English. Probably something like this:
Problems may occur when using Internet Explorer as the default browser. If this is the case, please change your web browser to e.g. Google Chrome, Microsoft Edge or Mozilla Firefox, then please use the Forgot Password function on the DiGA.Sax website.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed the other entries and therefore assumed that it must also be written in German.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it needs to be also corrected to other ones which are not written in English (some have already English text).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know, I will fix them!

@beatrycze-volk beatrycze-volk changed the title (add) new e-email text [MAINTENANCE] new e-email text Jan 23, 2025
@beatrycze-volk beatrycze-volk added maintenance Updates and upgrades and removed enhancement New feature or request labels Jan 23, 2025
@beatrycze-volk beatrycze-volk merged commit fc92fff into slub:master Jan 24, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Updates and upgrades
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants