Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified toggleFilter function in Chips Element Documentation #2154

Merged
merged 3 commits into from
Oct 20, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
color = c;
}

function filter(flavor: string): void {
function toggleFilter(flavor: string): void {
flavors[flavor] = !flavors[flavor];
}
</script>
Expand Down Expand Up @@ -161,7 +161,7 @@
<!-- prettier-ignore -->
<span
class="chip {flavors[f] ? 'variant-filled' : 'variant-soft'}"
on:click={() => { filter(f); }}
on:click={() => { toggleFilter(f); }}
on:keypress
>
{#if flavors[f]}<span><i class="fa-solid fa-check" /></span>{/if}
Expand All @@ -187,13 +187,13 @@ let flavors: Record<string, boolean> = {
{#each Object.keys(flavors) as f}
<span
class="chip {flavors[f] ? 'variant-filled' : 'variant-soft'}"
on:click={() => { filter(f); }}
on:click={() => { toggleFilter(f); }}
on:keypress
>
{#if flavors[f]}<span>(icon)</span>{/if}
<span class="capitalize">{f}</span>
</span>
{/each}
{/each}http://localhost:5173/
endigo9740 marked this conversation as resolved.
Show resolved Hide resolved
`}
/>
</svelte:fragment>
Expand Down