Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarified toggleFilter function in Chips Element Documentation #2154

Merged
merged 3 commits into from
Oct 20, 2023

Conversation

Sarenor
Copy link
Contributor

@Sarenor Sarenor commented Oct 18, 2023

Linked Issue

Discord thread

Description

Clarified toggleFilter function in Chips Element Documentation

  • This PR targets the dev branch (NEVER master)
  • Documentation reflects all relevant changes
  • Branch is prefixed with: docs/, feat/, chore/, bugfix/
  • Ensure Svelte and Typescript linting is current - run pnpm check
  • Ensure Prettier linting is current - run pnpm format
  • All test cases are passing - run pnpm test
  • Includes a changeset (if relevant; see above)

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

⚠️ No Changeset found

Latest commit: f5ae5a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
skeleton-docs ✅ Ready (Inspect) Visit Preview Oct 20, 2023 3:15pm

@endigo9740
Copy link
Contributor

endigo9740 commented Oct 20, 2023

@Sarenor I think your solution helped, but was missing one critical piece - the toggle function itself wasn't demonstrated to the end user. I've added this as the addition code block snippet in middle here:

Screenshot 2023-10-20 at 10 14 42 AM

I cannot recall why I originally introduced the term filter here at all. The use of toggle is much more semantic, so I've simplified it to this as well.

Thanks for the help!

@endigo9740 endigo9740 merged commit e92d056 into skeletonlabs:dev Oct 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants